You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/02/08 13:53:15 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5428: serial/pty: Close the internal pipe when reference count drop to zero

xiaoxiang781216 commented on a change in pull request #5428:
URL: https://github.com/apache/incubator-nuttx/pull/5428#discussion_r801653436



##########
File path: drivers/serial/pty.c
##########
@@ -153,14 +153,10 @@ struct pty_devpair_s
  ****************************************************************************/
 
 static int     pty_semtake(FAR struct pty_devpair_s *devpair);
-#ifndef CONFIG_DISABLE_PSEUDOFS_OPERATIONS

Review comment:
       Yes, pty can be deleted not only through unlink, but also through driver_unregister. The later api always exist regardless CONFIG_DISABLE_PSEUDOFS_OPERATIONS's setting.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org