[GitHub] [iceberg] flyrain commented on pull request #3557: Spark: Support vectorized reads with equality deletes

[GitBox <gi...@apache.org>]

flyrain commented on pull request #3557:
URL: https://github.com/apache/iceberg/pull/3557#issuecomment-993036558


   > I think this is good to go, There some fields that could. be marked as private, but it's an inner class so ... it probably doesn't matter. If you are good I can merge
   
   Thanks @RussellSpitzer for the review. It is a private internal class. Any field and method of the internal class will be public to its outer class, and private to any other classes. So the scope is the same with or without "private" modifier. It should be OK to not make them as private.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org