You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/02/07 15:14:25 UTC
[GitHub] [arrow-rs] jhorstmann opened a new pull request #1286: Fix simd comparison kernels
jhorstmann opened a new pull request #1286:
URL: https://github.com/apache/arrow-rs/pull/1286
# Which issue does this PR close?
<!---
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #1285 .
# Rationale for this change
The refactoring of the simd comparison in #1146 introduced silly mistake that was not noticed due to missing test coverage.
# What changes are included in this PR?
Apart from the bugfix, this adjusts the tests so they automatically also test a larger version of the test input and so cover the chunked part.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on pull request #1286: Fix simd comparison kernels
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #1286:
URL: https://github.com/apache/arrow-rs/pull/1286#issuecomment-1031701627
I plan to cherry-pick this and create a 9.0.1 branch / RC
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on pull request #1286: Fix simd comparison kernels
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #1286:
URL: https://github.com/apache/arrow-rs/pull/1286#issuecomment-1031692623
@jhorstmann -- I agree this seems serious -- I'll make a new RC to include this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on a change in pull request #1286: Fix simd comparison kernels
Posted by GitBox <gi...@apache.org>.
alamb commented on a change in pull request #1286:
URL: https://github.com/apache/arrow-rs/pull/1286#discussion_r800869101
##########
File path: arrow/src/compute/kernels/comparison.rs
##########
@@ -2442,6 +2442,20 @@ mod tests {
let b = b.slice(0, b.len());
let c = $DYN_KERNEL(a.as_ref(), b.as_ref()).unwrap();
assert_eq!(BooleanArray::from($EXPECTED), c);
+
Review comment:
👍 in case anyone else is curious, without the code fix, this test fails like this:
```shell
---- compute::kernels::comparison::tests::test_primitive_array_eq stdout ----
thread 'compute::kernels::comparison::tests::test_primitive_array_eq' panicked at 'assertion failed: `(left == right)`
left: `BooleanArray
[
false,
false,
true,
false,
false,
false,
false,
true,
false,
false,
...80 elements...,
false,
false,
true,
false,
false,
false,
false,
true,
false,
false,
]`,
right: `BooleanArray
[
false,
false,
true,
true,
true,
true,
true,
true,
true,
true,
...80 elements...,
false,
false,
true,
false,
false,
false,
false,
true,
false,
false,
]`', arrow/src/compute/kernels/comparison.rs:2486:9
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] jhorstmann commented on pull request #1286: Fix simd comparison kernels
Posted by GitBox <gi...@apache.org>.
jhorstmann commented on pull request #1286:
URL: https://github.com/apache/arrow-rs/pull/1286#issuecomment-1031605957
@alamb I'm sorry for only noticing this issue so late. Would be nice if we could still include it in the 9.0 release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb merged pull request #1286: Fix simd comparison kernels
Posted by GitBox <gi...@apache.org>.
alamb merged pull request #1286:
URL: https://github.com/apache/arrow-rs/pull/1286
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org