You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by arijitvt <gi...@git.apache.org> on 2015/04/16 02:33:00 UTC
[GitHub] thrift pull request: Resolved the thirft issue : 3067
GitHub user arijitvt opened a pull request:
https://github.com/apache/thrift/pull/444
Resolved the thirft issue : 3067
Implemented Changes related Thirft Jira Issue :3067
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/arijitvt/thrift THRIFT-3067
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/444.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #444
----
commit 865ef0f17d6e7645f2dbfd5da979e44cf1610d55
Author: Arijit Chattopadhyay <ar...@gmail.com>
Date: 2015-04-16T00:32:25Z
Resolved the thirft issue : 3067
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: Thrift-3067
Posted by arijitvt <gi...@git.apache.org>.
Github user arijitvt commented on the pull request:
https://github.com/apache/thrift/pull/444#issuecomment-96660406
Should I fix these changes and create a new pull request?
Arijit
On Mon, Apr 27, 2015 at 3:22 AM, Aki Sukegawa <no...@github.com>
wrote:
> @bufferoverflow <https://github.com/bufferoverflow>
> Could you revert (undo) part of the commit corresponding to third commit
> of this pull request ?
> This (d1aa530
> <https://github.com/apache/thrift/commit/d1aa53086c286bda716b7414eb04042999bb070a>)
> breaks Travis build by inserting non-code to YAML.
>
> By the way, the second one (711e608
> <https://github.com/apache/thrift/commit/711e6081fa8d31ffce3d6c431e0cd6c3dad9f050>)
> only breaks the style of existing code.
> It would be nice if this change is removed too.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/thrift/pull/444#issuecomment-96528996>.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: Thrift-3067
Posted by arijitvt <gi...@git.apache.org>.
Github user arijitvt closed the pull request at:
https://github.com/apache/thrift/pull/444
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: Thrift-3067
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/444
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: Thrift-3067
Posted by arijitvt <gi...@git.apache.org>.
GitHub user arijitvt reopened a pull request:
https://github.com/apache/thrift/pull/444
Thrift-3067
Implemented Changes related Thirft Jira Issue :3067
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/arijitvt/thrift THRIFT-3067
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/444.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #444
----
commit 865ef0f17d6e7645f2dbfd5da979e44cf1610d55
Author: Arijit Chattopadhyay <ar...@gmail.com>
Date: 2015-04-16T00:32:25Z
Resolved the thirft issue : 3067
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: Thrift-3067
Posted by arijitvt <gi...@git.apache.org>.
GitHub user arijitvt reopened a pull request:
https://github.com/apache/thrift/pull/444
Thrift-3067
Implemented Changes related Thirft Jira Issue :3067
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/arijitvt/thrift THRIFT-3067
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/444.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #444
----
commit 865ef0f17d6e7645f2dbfd5da979e44cf1610d55
Author: Arijit Chattopadhyay <ar...@gmail.com>
Date: 2015-04-16T00:32:25Z
Resolved the thirft issue : 3067
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: Thrift-3067
Posted by nsuke <gi...@git.apache.org>.
Github user nsuke commented on the pull request:
https://github.com/apache/thrift/pull/444#issuecomment-96528996
@bufferoverflow
Could you revert (undo) part of the commit corresponding to third commit of this pull request ?
This (d1aa53086c286bda716b7414eb04042999bb070a) breaks Travis build by inserting non-code to YAML.
By the way, the second one (711e6081fa8d31ffce3d6c431e0cd6c3dad9f050) only breaks the style of existing code.
It would be nice if this change is removed too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: Thrift-3067
Posted by arijitvt <gi...@git.apache.org>.
Github user arijitvt closed the pull request at:
https://github.com/apache/thrift/pull/444
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: Thrift-3067
Posted by arijitvt <gi...@git.apache.org>.
Github user arijitvt commented on the pull request:
https://github.com/apache/thrift/pull/444#issuecomment-93773899
Build failed for non-related issues. Will be reopening.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---