You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/10/07 00:22:05 UTC
[GitHub] [tvm] zxybazh opened a new pull request, #13006: [MetaSchedule][UX] Support Interactive Performance Table Printing in Notebook
zxybazh opened a new pull request, #13006:
URL: https://github.com/apache/tvm/pull/13006
This PR further addes interactive table printing functionality following #12866, now performance table are print in dataframe style if running in jupyter notebook. Sample notebook see [here](https://gist.github.com/zxybazh/f201698324c8ebd0beb10365738dd327)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] MasterJH5574 commented on a diff in pull request #13006: [MetaSchedule][UX] Support Interactive Performance Table Printing in Notebook
Posted by GitBox <gi...@apache.org>.
MasterJH5574 commented on code in PR #13006:
URL: https://github.com/apache/tvm/pull/13006#discussion_r995886681
##########
python/tvm/meta_schedule/logging.py:
##########
@@ -129,7 +133,7 @@ def create_loggers(
"class": "logging.FileHandler",
"filename": "{log_dir}/" + __name__ + ".task_scheduler.log",
"mode": "a",
- "level": "INFO",
+ "level": "DEBUG",
Review Comment:
Should we change line 114 to `"DEBUG"` as well?
##########
python/tvm/meta_schedule/logging.py:
##########
@@ -93,13 +93,16 @@ def create_loggers(
global_logger_name = "tvm.meta_schedule"
global_logger = logging.getLogger(global_logger_name)
+ console_logging_level = logging._levelToName[ # pylint: disable=protected-access
+ global_logger.level
+ ]
Review Comment:
If `global_logger.level` is `NOTSET` at this moment, `console_logging_level` will be a dash `"-"` and will be used on line 127. Just curious that if this is as expected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] MasterJH5574 merged pull request #13006: [MetaSchedule][UX] Support Interactive Performance Table Printing in Notebook
Posted by GitBox <gi...@apache.org>.
MasterJH5574 merged PR #13006:
URL: https://github.com/apache/tvm/pull/13006
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] zxybazh commented on a diff in pull request #13006: [MetaSchedule][UX] Support Interactive Performance Table Printing in Notebook
Posted by GitBox <gi...@apache.org>.
zxybazh commented on code in PR #13006:
URL: https://github.com/apache/tvm/pull/13006#discussion_r996162652
##########
python/tvm/meta_schedule/logging.py:
##########
@@ -129,7 +133,7 @@ def create_loggers(
"class": "logging.FileHandler",
"filename": "{log_dir}/" + __name__ + ".task_scheduler.log",
"mode": "a",
- "level": "INFO",
+ "level": "DEBUG",
Review Comment:
I agree it can be changed to `DEBUG`, but to clarify, all the use of `DEBUG` here are only for the support of outputing different text to file and console, for example, output interactive table to notebook and text table to log file. This does not impact per task logging and that's why this `INFO` level is kept there. Given they are not outputed to screen, I think change to `DEBUG` level still make sense, will do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] MasterJH5574 commented on a diff in pull request #13006: [MetaSchedule][UX] Support Interactive Performance Table Printing in Notebook
Posted by GitBox <gi...@apache.org>.
MasterJH5574 commented on code in PR #13006:
URL: https://github.com/apache/tvm/pull/13006#discussion_r992927437
##########
python/tvm/meta_schedule/logging.py:
##########
@@ -62,15 +62,15 @@ def get_logging_func(logger: Logger) -> Optional[Callable[[int, str], None]]:
# logging.FATAL not included
}
- def logging_func(level: int, msg: str):
- if level < 0:
+ def logging_func(level: int, file: str, lineo: int, msg: str):
Review Comment:
Do you think `file_name` is a better name?
```suggestion
def logging_func(level: int, file_name: str, lineo: int, msg: str):
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao commented on pull request #13006: [MetaSchedule][UX] Support Interactive Performance Table Printing in Notebook
Posted by GitBox <gi...@apache.org>.
junrushao commented on PR #13006:
URL: https://github.com/apache/tvm/pull/13006#issuecomment-1275317807
CC @MasterJH5574 @spectrometerHBH would you like to review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tvm-bot commented on pull request #13006: [MetaSchedule][UX] Support Interactive Performance Table Printing in Notebook
Posted by GitBox <gi...@apache.org>.
tvm-bot commented on PR #13006:
URL: https://github.com/apache/tvm/pull/13006#issuecomment-1276886579
<!---bot-comment-->
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
<!--bot-comment-docs-start-->
* Built docs for commit 531bee82376c14637cde837d2a29e4be77d78c2c can be found [here](https://pr-docs.tlcpack.ai/PR-13006/6/docs/index.html).<!--bot-comment-docs-end-->
<sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] zxybazh commented on a diff in pull request #13006: [MetaSchedule][UX] Support Interactive Performance Table Printing in Notebook
Posted by GitBox <gi...@apache.org>.
zxybazh commented on code in PR #13006:
URL: https://github.com/apache/tvm/pull/13006#discussion_r996155339
##########
python/tvm/meta_schedule/logging.py:
##########
@@ -93,13 +93,16 @@ def create_loggers(
global_logger_name = "tvm.meta_schedule"
global_logger = logging.getLogger(global_logger_name)
+ console_logging_level = logging._levelToName[ # pylint: disable=protected-access
+ global_logger.level
+ ]
Review Comment:
Thanks for spotting this, this is not expected, will take care of that!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] MasterJH5574 commented on a diff in pull request #13006: [MetaSchedule][UX] Support Interactive Performance Table Printing in Notebook
Posted by GitBox <gi...@apache.org>.
MasterJH5574 commented on code in PR #13006:
URL: https://github.com/apache/tvm/pull/13006#discussion_r996244804
##########
python/tvm/meta_schedule/logging.py:
##########
@@ -129,7 +133,7 @@ def create_loggers(
"class": "logging.FileHandler",
"filename": "{log_dir}/" + __name__ + ".task_scheduler.log",
"mode": "a",
- "level": "INFO",
+ "level": "DEBUG",
Review Comment:
Yeah I was just not sure about the difference between loggers and handlers and asked the question. Thanks for clarifying!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] zxybazh commented on pull request #13006: [MetaSchedule][UX] Support Interactive Performance Table Printing in Notebook
Posted by GitBox <gi...@apache.org>.
zxybazh commented on PR #13006:
URL: https://github.com/apache/tvm/pull/13006#issuecomment-1275268022
Ready for review and the current logger can:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao commented on a diff in pull request #13006: [MetaSchedule][UX] Support Interactive Performance Table Printing in Notebook
Posted by GitBox <gi...@apache.org>.
junrushao commented on code in PR #13006:
URL: https://github.com/apache/tvm/pull/13006#discussion_r992985813
##########
python/tvm/meta_schedule/logging.py:
##########
@@ -62,15 +62,15 @@ def get_logging_func(logger: Logger) -> Optional[Callable[[int, str], None]]:
# logging.FATAL not included
}
- def logging_func(level: int, msg: str):
- if level < 0:
+ def logging_func(level: int, file: str, lineo: int, msg: str):
Review Comment:
i think "filename" is probably a more frequent word (?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org