You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Michael Osipov <mi...@apache.org> on 2023/12/31 16:23:42 UTC
[VOTE] Release Maven Surefire version 3.2.4
Hi,
we solved 5 issues:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317927&version=12354030
There are still a couple of issues left in JIRA:
https://issues.apache.org/jira/issues/?jql=project%20%3D%20SUREFIRE%20AND%20resolution%20%3D%20Unresolved
Staging repo:
https://repository.apache.org/content/repositories/maven-2053/
https://repository.apache.org/content/repositories/maven-2053/org/apache/maven/surefire/surefire/3.2.4/surefire-3.2.4-source-release.zip
Source release checksum(s):
surefire-3.2.4-source-release.zip
sha512:
a18858d35b07483d7d175d161d022366eb1861541ed82c498d6860cff8e34552a42c37b3909cfebc620b949dfa2095571d324079e5bde03ec2c0839c164328e3
Staging site:
https://maven.apache.org/surefire-archives/surefire-LATEST/
Guide to testing staged releases:
https://maven.apache.org/guides/development/guide-testing-releases.html
Vote open for 72 hours.
[ ] +1
[ ] +0
[ ] -1
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [VOTE] Release Maven Surefire version 3.2.4
Posted by Michael Osipov <mi...@apache.org>.
Am 2023-12-31 um 21:33 schrieb Maarten Mulders:
> Here's (my) last vote of the year: +1
>
>
> - Maarten
>
>
> PS. I noticed that with this release, both Surefire and Failsafe start
> spitting out an extra message into the output that is not there in 3.2.3:
>
> [INFO] --- surefire:3.2.4:test (default-test) @ marky ---
> [INFO] Using auto detected provider
> org.apache.maven.surefire.junitplatform.JUnitPlatformProvider
> [INFO]
> [INFO] -------------------------------------------------------
> [INFO] T E S T S
> [INFO] -------------------------------------------------------
> ShellCommandline: [/bin/sh, -c, cd '<working-directory>' &&
> '<path-to-java-executable>' '-jar'
> '<working-directory>/target/surefire/surefirebooter-20231231212637775_3.jar' '<working-directory>/target/surefire' '2023-12-31T21-26-37_700-jvmRun1' 'surefire-20231231212637775_1tmp' 'surefire_0-20231231212637775_2tmp']
>
> I'm not really happy with this - I prefer my build logs to be short &
> sweet and I feel this adds noise. But I do not consider it a reason to
> cast a negative vote.
Thanks for testing..I had this temporary code while analyzing
SUREFIRE-2225. Can you while local repo and try over? I am currently
checking whether I have messed up the release.
M
Re: [VOTE] Release Maven Surefire version 3.2.4
Posted by Michael Osipov <mi...@apache.org>.
Am 2023-12-31 um 22:02 schrieb Maarten Mulders:
> On 31/12/2023 21:58, Michael Osipov wrote:
>> Am 2023-12-31 um 21:33 schrieb Maarten Mulders:
>>> Here's (my) last vote of the year: +1
>>>
>>>
>>> - Maarten
>>>
>>>
>>> PS. I noticed that with this release, both Surefire and Failsafe
>>> start spitting out an extra message into the output that is not there
>>> in 3.2.3:
>>>
>>> [INFO] --- surefire:3.2.4:test (default-test) @ marky ---
>>> [INFO] Using auto detected provider
>>> org.apache.maven.surefire.junitplatform.JUnitPlatformProvider
>>> [INFO]
>>> [INFO] -------------------------------------------------------
>>> [INFO] T E S T S
>>> [INFO] -------------------------------------------------------
>>> ShellCommandline: [/bin/sh, -c, cd '<working-directory>' &&
>>> '<path-to-java-executable>' '-jar'
>>> '<working-directory>/target/surefire/surefirebooter-20231231212637775_3.jar' '<working-directory>/target/surefire' '2023-12-31T21-26-37_700-jvmRun1' 'surefire-20231231212637775_1tmp' 'surefire_0-20231231212637775_2tmp']
>>>
>>> I'm not really happy with this - I prefer my build logs to be short &
>>> sweet and I feel this adds noise. But I do not consider it a reason
>>> to cast a negative vote.
>>
>> What you see is the result of:
>>> D:\Entwicklung\Projekte\maven-shared-utils
>>> [(maven-shared-utils-3.3.4) +0 ~1 -0 !]> git diff -w -U0
>>> diff --git
>>> a/src/main/java/org/apache/maven/shared/utils/cli/Commandline.java
>>> b/src/main/java/org/apache/maven/shared/utils/cli/Commandline.java
>>> index e03e905c2..b4ae25f66 100644
>>> --- a/src/main/java/org/apache/maven/shared/utils/cli/Commandline.java
>>> +++ b/src/main/java/org/apache/maven/shared/utils/cli/Commandline.java
>>> @@ -396,0 +397,2 @@ public class Commandline
>>> + String[] cl = getShellCommandline();
>>> + System.out.println( "ShellCommandline: " +
>>> Arrays.toString( cl ) );
>>> @@ -399 +401 @@ public class Commandline
>>> - process = Runtime.getRuntime().exec(
>>> getShellCommandline(), environment );
>>> + process = Runtime.getRuntime().exec( cl, environment );
>>> @@ -414 +416 @@ public class Commandline
>>> - process = Runtime.getRuntime().exec(
>>> getShellCommandline(), environment, workingDir );
>>> + process = Runtime.getRuntime().exec( cl,
>>> environment, workingDir );
>>
>> my local testing, but that should not arrive on your side. That is why
>> I am very confused about this...
>> I will try with a fesh local repo as well...
>
> I downloaded the JARs only tonight, so I'm afraid it must be in the
> release. But for good measure, I deleted
> ~/.m2/repository/org/apache/maven/surefire and tried again. The
> additional output is indeed still there...
Found it:
> [INFO] --- maven-shade-plugin:3.5.1:shade (default) @ surefire-shared-utils ---
> [INFO] Including org.apache.maven.shared:maven-shared-utils:jar:3.3.4 in the shaded jar.
> [INFO] Including commons-io:commons-io:jar:2.15.0 in the shaded jar.
> [INFO] Including org.apache.commons:commons-lang3:jar:3.14.0 in the shaded jar.
> [INFO] Including org.apache.commons:commons-compress:jar:1.25.0 in the shaded jar.
> [INFO] Dependency-reduced POM written at: D:\Entwicklung\Projekte\Maven Surefire\surefire-shared-utils\dependency-reduced-pom.xml
My locally modified version is shaded into Surefire. I will need to
reroll. Thanks for testing...
Re: [VOTE] Release Maven Surefire version 3.2.4
Posted by Maarten Mulders <mt...@apache.org>.
On 31/12/2023 21:58, Michael Osipov wrote:
> Am 2023-12-31 um 21:33 schrieb Maarten Mulders:
>> Here's (my) last vote of the year: +1
>>
>>
>> - Maarten
>>
>>
>> PS. I noticed that with this release, both Surefire and Failsafe start
>> spitting out an extra message into the output that is not there in 3.2.3:
>>
>> [INFO] --- surefire:3.2.4:test (default-test) @ marky ---
>> [INFO] Using auto detected provider
>> org.apache.maven.surefire.junitplatform.JUnitPlatformProvider
>> [INFO]
>> [INFO] -------------------------------------------------------
>> [INFO] T E S T S
>> [INFO] -------------------------------------------------------
>> ShellCommandline: [/bin/sh, -c, cd '<working-directory>' &&
>> '<path-to-java-executable>' '-jar'
>> '<working-directory>/target/surefire/surefirebooter-20231231212637775_3.jar' '<working-directory>/target/surefire' '2023-12-31T21-26-37_700-jvmRun1' 'surefire-20231231212637775_1tmp' 'surefire_0-20231231212637775_2tmp']
>>
>> I'm not really happy with this - I prefer my build logs to be short &
>> sweet and I feel this adds noise. But I do not consider it a reason to
>> cast a negative vote.
>
> What you see is the result of:
>> D:\Entwicklung\Projekte\maven-shared-utils [(maven-shared-utils-3.3.4)
>> +0 ~1 -0 !]> git diff -w -U0
>> diff --git
>> a/src/main/java/org/apache/maven/shared/utils/cli/Commandline.java
>> b/src/main/java/org/apache/maven/shared/utils/cli/Commandline.java
>> index e03e905c2..b4ae25f66 100644
>> --- a/src/main/java/org/apache/maven/shared/utils/cli/Commandline.java
>> +++ b/src/main/java/org/apache/maven/shared/utils/cli/Commandline.java
>> @@ -396,0 +397,2 @@ public class Commandline
>> + String[] cl = getShellCommandline();
>> + System.out.println( "ShellCommandline: " +
>> Arrays.toString( cl ) );
>> @@ -399 +401 @@ public class Commandline
>> - process = Runtime.getRuntime().exec(
>> getShellCommandline(), environment );
>> + process = Runtime.getRuntime().exec( cl, environment );
>> @@ -414 +416 @@ public class Commandline
>> - process = Runtime.getRuntime().exec(
>> getShellCommandline(), environment, workingDir );
>> + process = Runtime.getRuntime().exec( cl, environment,
>> workingDir );
>
> my local testing, but that should not arrive on your side. That is why I
> am very confused about this...
> I will try with a fesh local repo as well...
I downloaded the JARs only tonight, so I'm afraid it must be in the
release. But for good measure, I deleted
~/.m2/repository/org/apache/maven/surefire and tried again. The
additional output is indeed still there...
- Maarten
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [VOTE] Release Maven Surefire version 3.2.4
Posted by Michael Osipov <mi...@apache.org>.
Am 2023-12-31 um 21:33 schrieb Maarten Mulders:
> Here's (my) last vote of the year: +1
>
>
> - Maarten
>
>
> PS. I noticed that with this release, both Surefire and Failsafe start
> spitting out an extra message into the output that is not there in 3.2.3:
>
> [INFO] --- surefire:3.2.4:test (default-test) @ marky ---
> [INFO] Using auto detected provider
> org.apache.maven.surefire.junitplatform.JUnitPlatformProvider
> [INFO]
> [INFO] -------------------------------------------------------
> [INFO] T E S T S
> [INFO] -------------------------------------------------------
> ShellCommandline: [/bin/sh, -c, cd '<working-directory>' &&
> '<path-to-java-executable>' '-jar'
> '<working-directory>/target/surefire/surefirebooter-20231231212637775_3.jar' '<working-directory>/target/surefire' '2023-12-31T21-26-37_700-jvmRun1' 'surefire-20231231212637775_1tmp' 'surefire_0-20231231212637775_2tmp']
>
> I'm not really happy with this - I prefer my build logs to be short &
> sweet and I feel this adds noise. But I do not consider it a reason to
> cast a negative vote.
What you see is the result of:
> D:\Entwicklung\Projekte\maven-shared-utils [(maven-shared-utils-3.3.4) +0 ~1 -0 !]> git diff -w -U0
> diff --git a/src/main/java/org/apache/maven/shared/utils/cli/Commandline.java b/src/main/java/org/apache/maven/shared/utils/cli/Commandline.java
> index e03e905c2..b4ae25f66 100644
> --- a/src/main/java/org/apache/maven/shared/utils/cli/Commandline.java
> +++ b/src/main/java/org/apache/maven/shared/utils/cli/Commandline.java
> @@ -396,0 +397,2 @@ public class Commandline
> + String[] cl = getShellCommandline();
> + System.out.println( "ShellCommandline: " + Arrays.toString( cl ) );
> @@ -399 +401 @@ public class Commandline
> - process = Runtime.getRuntime().exec( getShellCommandline(), environment );
> + process = Runtime.getRuntime().exec( cl, environment );
> @@ -414 +416 @@ public class Commandline
> - process = Runtime.getRuntime().exec( getShellCommandline(), environment, workingDir );
> + process = Runtime.getRuntime().exec( cl, environment, workingDir );
my local testing, but that should not arrive on your side. That is why I
am very confused about this...
I will try with a fesh local repo as well...
Re: [VOTE] Release Maven Surefire version 3.2.4
Posted by Maarten Mulders <mt...@apache.org>.
Here's (my) last vote of the year: +1
- Maarten
PS. I noticed that with this release, both Surefire and Failsafe start
spitting out an extra message into the output that is not there in 3.2.3:
[INFO] --- surefire:3.2.4:test (default-test) @ marky ---
[INFO] Using auto detected provider
org.apache.maven.surefire.junitplatform.JUnitPlatformProvider
[INFO]
[INFO] -------------------------------------------------------
[INFO] T E S T S
[INFO] -------------------------------------------------------
ShellCommandline: [/bin/sh, -c, cd '<working-directory>' &&
'<path-to-java-executable>' '-jar'
'<working-directory>/target/surefire/surefirebooter-20231231212637775_3.jar'
'<working-directory>/target/surefire' '2023-12-31T21-26-37_700-jvmRun1'
'surefire-20231231212637775_1tmp' 'surefire_0-20231231212637775_2tmp']
I'm not really happy with this - I prefer my build logs to be short &
sweet and I feel this adds noise. But I do not consider it a reason to
cast a negative vote.
On 31/12/2023 17:24, Michael Osipov wrote:
> Last release of the year, enjoy guys!
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [VOTE] Release Maven Surefire version 3.2.4
Posted by Michael Osipov <mi...@apache.org>.
Last release of the year, enjoy guys!
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[CANCELED] [VOTE] Release Maven Surefire version 3.2.4
Posted by Michael Osipov <mi...@apache.org>.
Canceling the vote. Binary artifacts are flawed due to my manipulated
local repo. Will rebuild and reroll.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [CANCELED] [VOTE] Release Maven Surefire version 3.2.4
Posted by "Gary D. Gregory" <gg...@apache.org>.
Seeing there is an upcoming 3.2.5, I was holding up a new commons-parent, what's happening with 3.2.5?
Gary
On 2024/01/03 10:15:42 Michael Osipov wrote:
> I need to cancel the vote again. Marc Philipp found a regression: https://github.com/apache/maven-surefire/pull/702#discussion_r1439664959
>
> I will drop the staging repo, address the issue and respin as 3.2.5 shortly.
>
> M
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[CANCELED] [VOTE] Release Maven Surefire version 3.2.4
Posted by Michael Osipov <mi...@apache.org>.
I need to cancel the vote again. Marc Philipp found a regression: https://github.com/apache/maven-surefire/pull/702#discussion_r1439664959
I will drop the staging repo, address the issue and respin as 3.2.5 shortly.
M
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org