You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "janhoy (via GitHub)" <gi...@apache.org> on 2026/05/28 20:36:58 UTC
[PR] Rename osbenchmark/ → solrorbit/, remove other unused folders [solr-orbit]
janhoy opened a new pull request, #42:
URL: https://github.com/apache/solr-orbit/pull/42
Closes #14.
- Rename core Python package osbenchmark/ to solrorbit/ (git mv preserves history)
- Update all imports, entry points, logging config, and script references
- Remove solrbenchmark/ compatibility shim (no longer needed)
- Remove jenkins/ folder inherited from OpenSearch Benchmark (unused)
---
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] Rename osbenchmark/ → solrorbit/, remove other unused folders [solr-orbit]
Posted by "janhoy (via GitHub)" <gi...@apache.org>.
janhoy merged PR #42:
URL: https://github.com/apache/solr-orbit/pull/42
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] Rename osbenchmark/ → solrorbit/, remove other unused folders [solr-orbit]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #42:
URL: https://github.com/apache/solr-orbit/pull/42#discussion_r3320524173
##########
benchmark:
##########
@@ -39,7 +39,7 @@ cd "${BENCHMARK_SRC_HOME}" >/dev/null 2>&1
# set variables that are needed for run.sh
-__BENCHMARK_INTERNAL_BINARY_NAME="osbenchmark"
+__BENCHMARK_INTERNAL_BINARY_NAME="solrorbit"
Review Comment:
`__BENCHMARK_INTERNAL_BINARY_NAME` is set to `solrorbit`, but the packaged console script in `pyproject.toml` is named `solr-orbit`. As a result, `run.sh` will try to execute `${USER_BASE}/bin/solrorbit`, which likely won't exist after `pip install` (only `solr-orbit` will). Update this to `solr-orbit` (or add matching console scripts for `solrorbit`).
##########
CREATE_WORKLOAD_GUIDE.md:
##########
@@ -51,7 +51,7 @@ If you have a workload written for OpenSearch Benchmark, use the migration
utility to translate it to Solr format:
```bash
-python -m osbenchmark.tools.migrate_workload \
+python -m solrorbit.tools.migrate_workload \
Review Comment:
The guide references `python -m solrorbit.tools.migrate_workload`, but `solrorbit/tools/` currently contains only `__init__.py` (no `migrate_workload` module). This command will fail for users. Update the docs to point at the supported conversion entry point (e.g., the `solr-orbit convert-workload` subcommand or `solrorbit.conversion.workload_converter`).
##########
benchmarkd:
##########
@@ -41,7 +41,7 @@ cd "${BENCHMARK_SRC_HOME}" >/dev/null 2>&1
export PYTHONPATH="${BENCHMARK_SRC_HOME}:${PYTHONPATH:-}"
# set variables that are needed for run.sh
-__BENCHMARK_INTERNAL_BINARY_NAME="osbenchmarkd"
+__BENCHMARK_INTERNAL_BINARY_NAME="solrorbitd"
Review Comment:
`__BENCHMARK_INTERNAL_BINARY_NAME` is set to `solrorbitd`, but `pyproject.toml` defines the console script as `solr-orbitd`. This will make `run.sh` look for `${USER_BASE}/bin/solrorbitd` after installation, which likely doesn't exist. Align the internal binary name with the configured script name (or add a matching entry point).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org