You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/10/11 08:48:29 UTC
[GitHub] [netbeans] neilcsmith-net commented on a diff in pull request #4742: Add update centre notifications to Check for Updates dialog
neilcsmith-net commented on code in PR #4742:
URL: https://github.com/apache/netbeans/pull/4742#discussion_r992027538
##########
platform/autoupdate.ui/src/org/netbeans/modules/autoupdate/ui/wizards/LazyOperationDescriptionStep.java:
##########
@@ -186,25 +198,31 @@ public void taskFinished (Task task) {
@Override
public void run() {
JPanel body;
- if(problems==null || problems.isEmpty())
- {
- body = new OperationDescriptionPanel (
- getBundle ("LazyOperationDescriptionStep_NoUpdates_Title"), // NOI18N
- getBundle ("LazyOperationDescriptionStep_NoUpdates"), // NOI18N
- "", "",
- false);
- }
- else
- {
- body = new OperationDescriptionPanel (
- getBundle ("LazyOperationDescriptionStep_NoUpdatesWithProblems_Title"), // NOI18N
- getBundle ("LazyOperationDescriptionStep_NoUpdatesWithProblems"), // NOI18N
- "", "",
- false);
+ if (problems == null || problems.isEmpty()) {
+ if (notifications == null || notifications.isEmpty()) {
Review Comment:
True. I just kept the `notifications` logic the same as the `problems` one for consistency. I'm going to force push an update anyway - too many exclamation marks for my liking - so I'll change these too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists