Re: [PR] [thrift-remodel] Incorporate changes made to geospatial statistics [arrow-rs]

["etseidl (via GitHub)" <gi...@apache.org>]

etseidl commented on code in PR #8528:
URL: https://github.com/apache/arrow-rs/pull/8528#discussion_r2395288538


##########
parquet/src/basic.rs:
##########
@@ -456,9 +457,10 @@ impl<'a, R: ThriftCompactInputProtocol<'a>> ReadThrift<'a, R> for LogicalType {
             }
             18 => {
                 let val = GeographyType::read_thrift(&mut *prot)?;
+                let algorithm = val.algorithm.unwrap_or_default();

Review Comment:
   This change gives me the most pause. If the value is not set in the thrift, do we really want to set a default or leave it unset and handle that downstream?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org