You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by il...@apache.org on 2019/07/22 11:50:18 UTC

[dubbo-samples] branch master updated: enable integration test for generic impl samples

This is an automated email from the ASF dual-hosted git repository.

iluo pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/dubbo-samples.git


The following commit(s) were added to refs/heads/master by this push:
     new 8245e67  enable integration test for generic impl samples
8245e67 is described below

commit 8245e67577763a33040ea8ceae60b3b29835d6a4
Author: Ian Luo <ia...@gmail.com>
AuthorDate: Mon Jul 22 19:47:50 2019 +0800

    enable integration test for generic impl samples
---
 .../dubbo-samples-generic-impl-provider/pom.xml                        | 3 ---
 .../java/org/apache/dubbo/samples/generic/call/HelloServiceIT.java     | 2 ++
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/dubbo-samples-generic/dubbo-samples-generic-impl/dubbo-samples-generic-impl-provider/pom.xml b/dubbo-samples-generic/dubbo-samples-generic-impl/dubbo-samples-generic-impl-provider/pom.xml
index 0ede6ee..a8d97ba 100644
--- a/dubbo-samples-generic/dubbo-samples-generic-impl/dubbo-samples-generic-impl-provider/pom.xml
+++ b/dubbo-samples-generic/dubbo-samples-generic-impl/dubbo-samples-generic-impl-provider/pom.xml
@@ -175,8 +175,6 @@
                         </executions>
                     </plugin>
 
-                    <!-- FIXME: https://github.com/apache/dubbo-samples/issues/101 -->
-                    <!--
                     <plugin>
                         <groupId>org.apache.maven.plugins</groupId>
                         <artifactId>maven-failsafe-plugin</artifactId>
@@ -198,7 +196,6 @@
                             </execution>
                         </executions>
                     </plugin>
-                    -->
                 </plugins>
             </build>
         </profile>
diff --git a/dubbo-samples-generic/dubbo-samples-generic-impl/dubbo-samples-generic-impl-provider/src/test/java/org/apache/dubbo/samples/generic/call/HelloServiceIT.java b/dubbo-samples-generic/dubbo-samples-generic-impl/dubbo-samples-generic-impl-provider/src/test/java/org/apache/dubbo/samples/generic/call/HelloServiceIT.java
index cdde365..75035cb 100644
--- a/dubbo-samples-generic/dubbo-samples-generic-impl/dubbo-samples-generic-impl-provider/src/test/java/org/apache/dubbo/samples/generic/call/HelloServiceIT.java
+++ b/dubbo-samples-generic/dubbo-samples-generic-impl/dubbo-samples-generic-impl-provider/src/test/java/org/apache/dubbo/samples/generic/call/HelloServiceIT.java
@@ -21,6 +21,7 @@ import org.apache.dubbo.rpc.service.GenericException;
 import org.apache.dubbo.samples.generic.call.api.HelloService;
 
 import org.junit.Assert;
+import org.junit.Ignore;
 import org.junit.Test;
 import org.junit.runner.RunWith;
 import org.springframework.beans.factory.annotation.Autowired;
@@ -43,6 +44,7 @@ public class HelloServiceIT {
         Assert.assertEquals("sayHelloAsync: hello world", helloService.sayHelloAsync("world").get());
     }
 
+    @Ignore("FIXME: https://github.com/apache/dubbo/issues/4630")
     @Test(expected = GenericException.class)
     public void testNotImplementedHello() throws Exception {
         helloService.notImplementedHello("dubbo");


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org