You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Hudson (Jira)" <ji...@apache.org> on 2020/06/20 12:43:00 UTC
[jira] [Commented] (MNG-6942) Arbitrary file write during archive
extraction ("Zip Slip") in wrapper
[ https://issues.apache.org/jira/browse/MNG-6942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17141063#comment-17141063 ]
Hudson commented on MNG-6942:
-----------------------------
Build succeeded in Jenkins: Maven TLP » maven » master #431
See https://builds.apache.org/job/maven-box/job/maven/job/master/431/
> Arbitrary file write during archive extraction ("Zip Slip") in wrapper
> ----------------------------------------------------------------------
>
> Key: MNG-6942
> URL: https://issues.apache.org/jira/browse/MNG-6942
> Project: Maven
> Issue Type: Bug
> Components: maven wrapper
> Affects Versions: 3.7.0
> Reporter: Sylwester Lachiewicz
> Assignee: Robert Scholte
> Priority: Major
>
> In Maven Wrapper Installer [https://github.com/apache/maven/blob/ef8c95eb397651e10f677763dfcd9c8cea7c27b0/maven-wrapper/src/main/java/org/apache/maven/wrapper/Installer.java]
>
> {code:java}
> ZipEntry entry = entries.nextElement();
> if ( entry.isDirectory() )
> {
> continue;
> }
> Path targetFile = dest.resolve( entry.getName() );
> // Unsanitized archive entry, which may contain '..', is used in a file system operation.
> // prevent Zip Slip
> if ( targetFile.startsWith( dest ) )
> {
> Files.createDirectories( targetFile.getParent() );
> Files.copy( zipFile.getInputStream( entry ), targetFile );
> }
> {code}
>
> Found via LGTM.com scan
--
This message was sent by Atlassian Jira
(v8.3.4#803005)