You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Neelesh Srinivas Salian (JIRA)" <ji...@apache.org> on 2016/07/28 19:25:20 UTC
[jira] [Commented] (FLINK-4278) Unclosed FSDataOutputStream in
multiple files in the project
[ https://issues.apache.org/jira/browse/FLINK-4278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15398081#comment-15398081 ]
Neelesh Srinivas Salian commented on FLINK-4278:
------------------------------------------------
[~tedyu] any thoughts how this can be achieved.
Can Post a PR based on the discussion
> Unclosed FSDataOutputStream in multiple files in the project
> ------------------------------------------------------------
>
> Key: FLINK-4278
> URL: https://issues.apache.org/jira/browse/FLINK-4278
> Project: Flink
> Issue Type: Bug
> Affects Versions: 1.0.3
> Reporter: Neelesh Srinivas Salian
> Assignee: Neelesh Srinivas Salian
>
> After FLINK-4259, I did a check and found that the following files don't have the closing of the FSDataOutputStream.
> The following are the files and the corresponding methods missing the close()
> 1) FSDataOutputStream.java adding a close method in the abstract class
> 2) FSStateBackend flush() and write() - closing the FSDataOutputStream
> 3) StringWriter.java write()
> 4) FileSystemStateStore putState() - closing the FSDataOutputStream
> 5) HadoopDataOutputStream.java not too sure if this needs closing.
> 6) FileSystemStateStorageHelper.java store() need closing for both outStream and the ObjectOutputStream
> The options to think would be to either close or use IOUtils.closeQuietly()
> Any thoughts?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)