You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/04/27 17:30:09 UTC
[GitHub] [spark] jose-torres opened a new pull request #32371: [SPARK-35246][SS] Don't allow streaming-batch intersects.
jose-torres opened a new pull request #32371:
URL: https://github.com/apache/spark/pull/32371
### What changes were proposed in this pull request?
The UnsupportedOperationChecker shouldn't allow streaming-batch intersects. As described in the ticket, they can't actually be planned correctly, and even simple cases like the below will fail:
```
test("intersect") {
val input = MemoryStream[Long]
val df = input.toDS().intersect(spark.range(10).as[Long])
testStream(df) (
AddData(input, 1L),
CheckAnswer(1)
)
}
```
### Why are the changes needed?
Users will be confused by the cryptic errors produced from trying to run an invalid query plan.
### Does this PR introduce _any_ user-facing change?
Some queries which previously failed with a poor error will now fail with a better one.
### How was this patch tested?
modified unit test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32371: [SPARK-35246][SS] Don't allow streaming-batch intersects.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32371:
URL: https://github.com/apache/spark/pull/32371#issuecomment-827962950
**[Test build #138004 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138004/testReport)** for PR 32371 at commit [`0e67638`](https://github.com/apache/spark/commit/0e67638e5c84522d0bd623e1d4bfc2838c60118a).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32371: [SPARK-35246][SS] Don't allow streaming-batch intersects.
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32371:
URL: https://github.com/apache/spark/pull/32371#issuecomment-827783502
**[Test build #138004 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138004/testReport)** for PR 32371 at commit [`0e67638`](https://github.com/apache/spark/commit/0e67638e5c84522d0bd623e1d4bfc2838c60118a).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #32371: [SPARK-35246][SS] Don't allow streaming-batch intersects.
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #32371:
URL: https://github.com/apache/spark/pull/32371
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32371: [SPARK-35246][SS] Don't allow streaming-batch intersects.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32371:
URL: https://github.com/apache/spark/pull/32371#issuecomment-827784341
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32371: [SPARK-35246][SS] Don't allow streaming-batch intersects.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32371:
URL: https://github.com/apache/spark/pull/32371#issuecomment-827784341
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32371: [SPARK-35246][SS] Don't allow streaming-batch intersects.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32371:
URL: https://github.com/apache/spark/pull/32371#issuecomment-827978236
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #32371: [SPARK-35246][SS] Don't allow streaming-batch intersects.
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #32371:
URL: https://github.com/apache/spark/pull/32371#issuecomment-828078199
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32371: [SPARK-35246][SS] Don't allow streaming-batch intersects.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32371:
URL: https://github.com/apache/spark/pull/32371#issuecomment-827783502
**[Test build #138004 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138004/testReport)** for PR 32371 at commit [`0e67638`](https://github.com/apache/spark/commit/0e67638e5c84522d0bd623e1d4bfc2838c60118a).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org