You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "Jörg Hoh (Created JIRA)" <ji...@apache.org> on 2011/12/19 23:09:32 UTC
[jira] [Created] (JCR-3186) Export size of Observation eventQueue
to JMX
Export size of Observation eventQueue to JMX
--------------------------------------------
Key: JCR-3186
URL: https://issues.apache.org/jira/browse/JCR-3186
Project: Jackrabbit Content Repository
Issue Type: New Feature
Components: jackrabbit-core
Reporter: Jörg Hoh
Priority: Minor
export the size of the event queue of JCR Observation to JMX.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (JCR-3186) Export size of Observation eventQueue
to JMX
Posted by "Alex Parvulescu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13221035#comment-13221035 ]
Alex Parvulescu commented on JCR-3186:
--------------------------------------
It is interesting that we already have the counter info, and it would be extremely simple to turn that into a counter managed by the RepositoryStatistics, which in turn can qualify it as an exposed statistic.
This implies that we have to find a way to get the RepositoryStatistics object from the ObservationDispatcher.
One way is to change the default constructor to take the RepositoryContext as a param:
public ObservationDispatcher() would become
public ObservationDispatcher(RepositoryContext rc)
Or add another constructor (besides the default one) that takes the RepositoryContext as a param. This would make the difference between a managed counter and a simple AtomicLong for the queue size.
I see no cleaner way of getting the RepositoryStatistics object from the ObservationDispatcher.
thoughts?
> Export size of Observation eventQueue to JMX
> --------------------------------------------
>
> Key: JCR-3186
> URL: https://issues.apache.org/jira/browse/JCR-3186
> Project: Jackrabbit Content Repository
> Issue Type: Wish
> Components: jackrabbit-core
> Reporter: Jörg Hoh
> Priority: Minor
> Attachments: JR-observationQueueJMX-trunk.patch
>
>
> export the size of the event queue of JCR Observation to JMX.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (JCR-3186) Export size of Observation eventQueue
to JMX
Posted by "Jörg Hoh (Updated JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jörg Hoh updated JCR-3186:
--------------------------
Attachment: JR-observationQueueJMX-trunk.patch
> Export size of Observation eventQueue to JMX
> --------------------------------------------
>
> Key: JCR-3186
> URL: https://issues.apache.org/jira/browse/JCR-3186
> Project: Jackrabbit Content Repository
> Issue Type: New Feature
> Components: jackrabbit-core
> Reporter: Jörg Hoh
> Priority: Minor
> Attachments: JR-observationQueueJMX-trunk.patch
>
>
> export the size of the event queue of JCR Observation to JMX.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (JCR-3186) Export size of Observation eventQueue
to JMX
Posted by "Julian Reschke (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Julian Reschke updated JCR-3186:
--------------------------------
Issue Type: Sub-task (was: New Feature)
Parent: JCR-2936
> Export size of Observation eventQueue to JMX
> --------------------------------------------
>
> Key: JCR-3186
> URL: https://issues.apache.org/jira/browse/JCR-3186
> Project: Jackrabbit Content Repository
> Issue Type: Sub-task
> Components: jackrabbit-core
> Reporter: Jörg Hoh
> Assignee: Julian Reschke
> Priority: Minor
> Attachments: JR-observationQueueJMX-trunk.patch
>
>
> export the size of the event queue of JCR Observation to JMX.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (JCR-3186) Export size of Observation eventQueue
to JMX
Posted by "Julian Reschke (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Julian Reschke updated JCR-3186:
--------------------------------
Issue Type: Wish (was: Sub-task)
Parent: (was: JCR-2936)
> Export size of Observation eventQueue to JMX
> --------------------------------------------
>
> Key: JCR-3186
> URL: https://issues.apache.org/jira/browse/JCR-3186
> Project: Jackrabbit Content Repository
> Issue Type: Wish
> Components: jackrabbit-core
> Reporter: Jörg Hoh
> Assignee: Julian Reschke
> Priority: Minor
> Attachments: JR-observationQueueJMX-trunk.patch
>
>
> export the size of the event queue of JCR Observation to JMX.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (JCR-3186) Export size of Observation eventQueue
to JMX
Posted by "Julian Reschke (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Julian Reschke updated JCR-3186:
--------------------------------
Assignee: (was: Julian Reschke)
> Export size of Observation eventQueue to JMX
> --------------------------------------------
>
> Key: JCR-3186
> URL: https://issues.apache.org/jira/browse/JCR-3186
> Project: Jackrabbit Content Repository
> Issue Type: Wish
> Components: jackrabbit-core
> Reporter: Jörg Hoh
> Priority: Minor
> Attachments: JR-observationQueueJMX-trunk.patch
>
>
> export the size of the event queue of JCR Observation to JMX.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (JCR-3186) Export size of Observation eventQueue
to JMX
Posted by "Jörg Hoh (Commented JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13172669#comment-13172669 ]
Jörg Hoh commented on JCR-3186:
-------------------------------
the attached patch introduces a new interface ObservationManagerMBean interface and make the ObservationDispatcher implement it.
> Export size of Observation eventQueue to JMX
> --------------------------------------------
>
> Key: JCR-3186
> URL: https://issues.apache.org/jira/browse/JCR-3186
> Project: Jackrabbit Content Repository
> Issue Type: New Feature
> Components: jackrabbit-core
> Reporter: Jörg Hoh
> Priority: Minor
>
> export the size of the event queue of JCR Observation to JMX.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (JCR-3186) Export size of Observation eventQueue
to JMX
Posted by "Jukka Zitting (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13227438#comment-13227438 ]
Jukka Zitting commented on JCR-3186:
------------------------------------
Like Alex, I'd ideally see this as an extra TimeSeries instance.
> I see no cleaner way of getting the RepositoryStatistics object from the ObservationDispatcher.
Instead of building extra responsibilities into the ObservationDispatcher class (that's already fairly complex), I'd like to see it simply expose the queue size with a simple getter method, and leave it up to a separate class to turn that information into a TimeSeries.
> Export size of Observation eventQueue to JMX
> --------------------------------------------
>
> Key: JCR-3186
> URL: https://issues.apache.org/jira/browse/JCR-3186
> Project: Jackrabbit Content Repository
> Issue Type: Wish
> Components: jackrabbit-core
> Reporter: Jörg Hoh
> Priority: Minor
> Attachments: JR-observationQueueJMX-trunk.patch
>
>
> export the size of the event queue of JCR Observation to JMX.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (JCR-3186) Export size of Observation eventQueue
to JMX
Posted by "Julian Reschke (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Julian Reschke reassigned JCR-3186:
-----------------------------------
Assignee: Julian Reschke
> Export size of Observation eventQueue to JMX
> --------------------------------------------
>
> Key: JCR-3186
> URL: https://issues.apache.org/jira/browse/JCR-3186
> Project: Jackrabbit Content Repository
> Issue Type: New Feature
> Components: jackrabbit-core
> Reporter: Jörg Hoh
> Assignee: Julian Reschke
> Priority: Minor
> Attachments: JR-observationQueueJMX-trunk.patch
>
>
> export the size of the event queue of JCR Observation to JMX.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (JCR-3186) Export size of Observation eventQueue
to JMX
Posted by "Alex Parvulescu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13227687#comment-13227687 ]
Alex Parvulescu commented on JCR-3186:
--------------------------------------
> ObservationDispatcher class (that's already fairly complex)
agreed.
We can add the getter, but I don't see how to transform it into a TimeSeries.
If you're willing to explain it, I'm willing to turn in into code :)
> Export size of Observation eventQueue to JMX
> --------------------------------------------
>
> Key: JCR-3186
> URL: https://issues.apache.org/jira/browse/JCR-3186
> Project: Jackrabbit Content Repository
> Issue Type: Wish
> Components: jackrabbit-core
> Reporter: Jörg Hoh
> Priority: Minor
> Attachments: JR-observationQueueJMX-trunk.patch
>
>
> export the size of the event queue of JCR Observation to JMX.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (JCR-3186) Export size of Observation eventQueue
to JMX
Posted by "Alex Parvulescu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alex Parvulescu updated JCR-3186:
---------------------------------
Attachment: JCR-3186.patch
I'm trying out a different approach.
Let's see how it looks like if the ObservationDispatcher maintains and exposes its own stat object.
To be able to maintain the stats object up to date it will need an executor. I've added a new constructor so we can pass in the repository's central executor for the updates.
For now, no executor means no stats update. We may need to reconsider this in the future if it proves not sufficient enough.
attached proposed patch.
> Export size of Observation eventQueue to JMX
> --------------------------------------------
>
> Key: JCR-3186
> URL: https://issues.apache.org/jira/browse/JCR-3186
> Project: Jackrabbit Content Repository
> Issue Type: Wish
> Components: jackrabbit-core
> Reporter: Jörg Hoh
> Priority: Minor
> Attachments: JCR-3186.patch, JR-observationQueueJMX-trunk.patch
>
>
> export the size of the event queue of JCR Observation to JMX.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira