You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Niklas Nielsen <ni...@qni.dk> on 2015/05/27 19:39:36 UTC

Review Request 34719: Added QOS_KILLED as status reason

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34719/
-----------------------------------------------------------

Review request for mesos, Bartek Plotka, Jie Yu, Joris Van Remoortere, and Vinod Kone.


Bugs: MESOS-2653
    https://issues.apache.org/jira/browse/MESOS-2653


Repository: mesos


Description
-------

See summary


Diffs
-----

  include/mesos/mesos.proto a66888916dc90e476c8bb20e67e3f6b08c47fb99 

Diff: https://reviews.apache.org/r/34719/diff/


Testing
-------

make check


Thanks,

Niklas Nielsen

Re: Review Request 34719: Added QOS_KILLED as status reason

Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34719/#review86929
-----------------------------------------------------------

Ship it!


Ship It!

- Till Toenshoff


On June 4, 2015, 5:43 p.m., Niklas Nielsen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34719/
> -----------------------------------------------------------
> 
> (Updated June 4, 2015, 5:43 p.m.)
> 
> 
> Review request for mesos, Bartek Plotka, Jie Yu, Joris Van Remoortere, and Vinod Kone.
> 
> 
> Bugs: MESOS-2653
>     https://issues.apache.org/jira/browse/MESOS-2653
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 6186c92c6fe9cf8fa136d93d5af43e0377406baf 
> 
> Diff: https://reviews.apache.org/r/34719/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Niklas Nielsen
> 
>

Re: Review Request 34719: Added QOS_KILLED as status reason

Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34719/#review87246
-----------------------------------------------------------


Keeping this patch set open, as the terminal reason work is coming up and shouldn't change this set dramatically.

Please defer from reviewing until the terminal reason set is up (and marked as a blocker for this set).

- Niklas Nielsen


On June 4, 2015, 10:43 a.m., Niklas Nielsen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34719/
> -----------------------------------------------------------
> 
> (Updated June 4, 2015, 10:43 a.m.)
> 
> 
> Review request for mesos, Bartek Plotka, Jie Yu, Joris Van Remoortere, and Vinod Kone.
> 
> 
> Bugs: MESOS-2653
>     https://issues.apache.org/jira/browse/MESOS-2653
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 6186c92c6fe9cf8fa136d93d5af43e0377406baf 
> 
> Diff: https://reviews.apache.org/r/34719/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Niklas Nielsen
> 
>

Re: Review Request 34719: Added REASON_EXECUTOR_PREEMPTED as status reason.

Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34719/#review88123
-----------------------------------------------------------

Ship it!



include/mesos/mesos.proto (line 902)
<https://reviews.apache.org/r/34719/#comment140519>

    Can you put this close to REASON_EXECUTOR_XXX?


- Jie Yu


On June 16, 2015, 8:40 p.m., Niklas Nielsen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34719/
> -----------------------------------------------------------
> 
> (Updated June 16, 2015, 8:40 p.m.)
> 
> 
> Review request for mesos, Bartek Plotka, Jie Yu, Joris Van Remoortere, and Vinod Kone.
> 
> 
> Bugs: MESOS-2653
>     https://issues.apache.org/jira/browse/MESOS-2653
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto e5b988498e7560af192a52d8d54fbf75d6966f9f 
> 
> Diff: https://reviews.apache.org/r/34719/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Niklas Nielsen
> 
>

Re: Review Request 34719: Added REASON_EXECUTOR_PREEMPTED as status reason.

Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34719/
-----------------------------------------------------------

(Updated June 16, 2015, 4:45 p.m.)


Review request for mesos, Bartek Plotka, Jie Yu, Joris Van Remoortere, and Vinod Kone.


Bugs: MESOS-2653
    https://issues.apache.org/jira/browse/MESOS-2653


Repository: mesos


Description
-------

See summary


Diffs (updated)
-----

  include/mesos/mesos.proto e5b988498e7560af192a52d8d54fbf75d6966f9f 

Diff: https://reviews.apache.org/r/34719/diff/


Testing
-------

make check


Thanks,

Niklas Nielsen

Re: Review Request 34719: Added REASON_EXECUTOR_PREEMPTED as status reason.

Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34719/
-----------------------------------------------------------

(Updated June 16, 2015, 1:40 p.m.)


Review request for mesos, Bartek Plotka, Jie Yu, Joris Van Remoortere, and Vinod Kone.


Summary (updated)
-----------------

Added REASON_EXECUTOR_PREEMPTED as status reason.


Bugs: MESOS-2653
    https://issues.apache.org/jira/browse/MESOS-2653


Repository: mesos


Description
-------

See summary


Diffs (updated)
-----

  include/mesos/mesos.proto e5b988498e7560af192a52d8d54fbf75d6966f9f 

Diff: https://reviews.apache.org/r/34719/diff/


Testing
-------

make check


Thanks,

Niklas Nielsen

Re: Review Request 34719: Added QOS_KILLED as status reason

Posted by Vinod Kone <vi...@gmail.com>.

> On June 12, 2015, 10 p.m., Jie Yu wrote:
> > include/mesos/mesos.proto, line 875
> > <https://reviews.apache.org/r/34719/diff/4/?file=983929#file983929line875>
> >
> >     REASON_EXECUTOR_PREEMPTED ?
> >     
> >     cc @vinod @bmahler

SGTM.


- Vinod


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34719/#review87764
-----------------------------------------------------------


On June 12, 2015, 9:48 p.m., Niklas Nielsen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34719/
> -----------------------------------------------------------
> 
> (Updated June 12, 2015, 9:48 p.m.)
> 
> 
> Review request for mesos, Bartek Plotka, Jie Yu, Joris Van Remoortere, and Vinod Kone.
> 
> 
> Bugs: MESOS-2653
>     https://issues.apache.org/jira/browse/MESOS-2653
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 20340099dc87b3ea7f375c50fa3848ab5b0d5134 
> 
> Diff: https://reviews.apache.org/r/34719/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Niklas Nielsen
> 
>

Re: Review Request 34719: Added QOS_KILLED as status reason

Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34719/#review87764
-----------------------------------------------------------



include/mesos/mesos.proto
<https://reviews.apache.org/r/34719/#comment140182>

    REASON_EXECUTOR_PREEMPTED ?
    
    cc @vinod @bmahler


- Jie Yu


On June 12, 2015, 9:48 p.m., Niklas Nielsen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34719/
> -----------------------------------------------------------
> 
> (Updated June 12, 2015, 9:48 p.m.)
> 
> 
> Review request for mesos, Bartek Plotka, Jie Yu, Joris Van Remoortere, and Vinod Kone.
> 
> 
> Bugs: MESOS-2653
>     https://issues.apache.org/jira/browse/MESOS-2653
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 20340099dc87b3ea7f375c50fa3848ab5b0d5134 
> 
> Diff: https://reviews.apache.org/r/34719/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Niklas Nielsen
> 
>

Re: Review Request 34719: Added QOS_KILLED as status reason

Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34719/
-----------------------------------------------------------

(Updated June 12, 2015, 2:48 p.m.)


Review request for mesos, Bartek Plotka, Jie Yu, Joris Van Remoortere, and Vinod Kone.


Bugs: MESOS-2653
    https://issues.apache.org/jira/browse/MESOS-2653


Repository: mesos


Description
-------

See summary


Diffs (updated)
-----

  include/mesos/mesos.proto 20340099dc87b3ea7f375c50fa3848ab5b0d5134 

Diff: https://reviews.apache.org/r/34719/diff/


Testing
-------

make check


Thanks,

Niklas Nielsen

Re: Review Request 34719: Added QOS_KILLED as status reason

Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34719/
-----------------------------------------------------------

(Updated June 11, 2015, 3:58 p.m.)


Review request for mesos, Bartek Plotka, Jie Yu, Joris Van Remoortere, and Vinod Kone.


Bugs: MESOS-2653
    https://issues.apache.org/jira/browse/MESOS-2653


Repository: mesos


Description
-------

See summary


Diffs (updated)
-----

  include/mesos/mesos.proto 20340099dc87b3ea7f375c50fa3848ab5b0d5134 

Diff: https://reviews.apache.org/r/34719/diff/


Testing
-------

make check


Thanks,

Niklas Nielsen

Re: Review Request 34719: Added QOS_KILLED as status reason

Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34719/
-----------------------------------------------------------

(Updated June 4, 2015, 10:43 a.m.)


Review request for mesos, Bartek Plotka, Jie Yu, Joris Van Remoortere, and Vinod Kone.


Bugs: MESOS-2653
    https://issues.apache.org/jira/browse/MESOS-2653


Repository: mesos


Description
-------

See summary


Diffs (updated)
-----

  include/mesos/mesos.proto 6186c92c6fe9cf8fa136d93d5af43e0377406baf 

Diff: https://reviews.apache.org/r/34719/diff/


Testing
-------

make check


Thanks,

Niklas Nielsen