You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Lars Volker (Code Review)" <ge...@cloudera.org> on 2019/04/15 18:50:20 UTC

[Impala-ASF-CR] IMPALA-8413: Don't assume non-zero network counters in tests 

Lars Volker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13017


Change subject: IMPALA-8413: Don't assume non-zero network counters in tests
......................................................................

IMPALA-8413: Don't assume non-zero network counters in tests

In virtualized test environments (e.g. docker) we have seen cases where
some of the network counters are still zero when the
system-state-info-test runs. This change adjusts the test to allow
counters to be zero, since other tests make sure that non-zero values
are parsed correctly.

Change-Id: I39e18510b1c20749e218748eaaffb74abeae4ebe
---
M be/src/util/system-state-info-test.cc
1 file changed, 6 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/17/13017/1
-- 
To view, visit http://gerrit.cloudera.org:8080/13017
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I39e18510b1c20749e218748eaaffb74abeae4ebe
Gerrit-Change-Number: 13017
Gerrit-PatchSet: 1
Gerrit-Owner: Lars Volker <lv...@cloudera.com>

[Impala-ASF-CR] IMPALA-8413: Don't assume non-zero network counters in tests

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13017 )

Change subject: IMPALA-8413: Don't assume non-zero network counters in tests
......................................................................


Patch Set 1: Code-Review+2

maybe leave the JIRA in the comment?


-- 
To view, visit http://gerrit.cloudera.org:8080/13017
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I39e18510b1c20749e218748eaaffb74abeae4ebe
Gerrit-Change-Number: 13017
Gerrit-PatchSet: 1
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 15 Apr 2019 21:30:23 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8413: Don't assume non-zero network counters in tests

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13017 )

Change subject: IMPALA-8413: Don't assume non-zero network counters in tests
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/2789/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/13017
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I39e18510b1c20749e218748eaaffb74abeae4ebe
Gerrit-Change-Number: 13017
Gerrit-PatchSet: 2
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 15 Apr 2019 22:18:10 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8413: Don't assume non-zero network counters in tests

Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/13017 )

Change subject: IMPALA-8413: Don't assume non-zero network counters in tests
......................................................................


Patch Set 2: Code-Review+2

Carrying Tim's +2


-- 
To view, visit http://gerrit.cloudera.org:8080/13017
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I39e18510b1c20749e218748eaaffb74abeae4ebe
Gerrit-Change-Number: 13017
Gerrit-PatchSet: 2
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 15 Apr 2019 21:32:16 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8413: Don't assume non-zero network counters in tests

Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Hello Tim Armstrong, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/13017

to look at the new patch set (#2).

Change subject: IMPALA-8413: Don't assume non-zero network counters in tests
......................................................................

IMPALA-8413: Don't assume non-zero network counters in tests

In virtualized test environments (e.g. docker) we have seen cases where
some of the network counters are still zero when the
system-state-info-test runs. This change adjusts the test to allow
counters to be zero, since other tests make sure that non-zero values
are parsed correctly.

Change-Id: I39e18510b1c20749e218748eaaffb74abeae4ebe
---
M be/src/util/system-state-info-test.cc
1 file changed, 6 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/17/13017/2
-- 
To view, visit http://gerrit.cloudera.org:8080/13017
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I39e18510b1c20749e218748eaaffb74abeae4ebe
Gerrit-Change-Number: 13017
Gerrit-PatchSet: 2
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-8413: Don't assume non-zero network counters in tests

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13017 )

Change subject: IMPALA-8413: Don't assume non-zero network counters in tests
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/2783/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/13017
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I39e18510b1c20749e218748eaaffb74abeae4ebe
Gerrit-Change-Number: 13017
Gerrit-PatchSet: 1
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 15 Apr 2019 19:12:19 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8413: Don't assume non-zero network counters in tests

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13017 )

Change subject: IMPALA-8413: Don't assume non-zero network counters in tests
......................................................................


Patch Set 3: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/13017
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I39e18510b1c20749e218748eaaffb74abeae4ebe
Gerrit-Change-Number: 13017
Gerrit-PatchSet: 3
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 16 Apr 2019 02:46:08 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8413: Don't assume non-zero network counters in tests

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13017 )

Change subject: IMPALA-8413: Don't assume non-zero network counters in tests
......................................................................

IMPALA-8413: Don't assume non-zero network counters in tests

In virtualized test environments (e.g. docker) we have seen cases where
some of the network counters are still zero when the
system-state-info-test runs. This change adjusts the test to allow
counters to be zero, since other tests make sure that non-zero values
are parsed correctly.

Change-Id: I39e18510b1c20749e218748eaaffb74abeae4ebe
Reviewed-on: http://gerrit.cloudera.org:8080/13017
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/util/system-state-info-test.cc
1 file changed, 6 insertions(+), 4 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/13017
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I39e18510b1c20749e218748eaaffb74abeae4ebe
Gerrit-Change-Number: 13017
Gerrit-PatchSet: 4
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-8413: Don't assume non-zero network counters in tests

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13017 )

Change subject: IMPALA-8413: Don't assume non-zero network counters in tests
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/13017
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I39e18510b1c20749e218748eaaffb74abeae4ebe
Gerrit-Change-Number: 13017
Gerrit-PatchSet: 3
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 15 Apr 2019 21:32:25 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8413: Don't assume non-zero network counters in tests

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13017 )

Change subject: IMPALA-8413: Don't assume non-zero network counters in tests
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4022/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/13017
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I39e18510b1c20749e218748eaaffb74abeae4ebe
Gerrit-Change-Number: 13017
Gerrit-PatchSet: 3
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 15 Apr 2019 21:32:26 +0000
Gerrit-HasComments: No