You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by SolidWallOfCode <gi...@git.apache.org> on 2016/10/18 16:01:08 UTC
[GitHub] trafficserver pull request #1116: TS-4979: Fix coverity complaint about pote...
GitHub user SolidWallOfCode opened a pull request:
https://github.com/apache/trafficserver/pull/1116
TS-4979: Fix coverity complaint about potential null pointer.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/SolidWallOfCode/trafficserver ts-4979
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/1116.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1116
----
commit ea965643027e96a22016b3c916ecbeb7ee2fa0ee
Author: Alan M. Carroll <so...@yahoo-inc.com>
Date: 2016-10-18T16:00:07Z
TS-4979: Fix coverity complaint about potential null pointer.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1116: TS-4979: Fix clang-analyzer complaint abou...
Posted by SolidWallOfCode <gi...@git.apache.org>.
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1116#discussion_r83902560
--- Diff: proxy/http/HttpTransact.cc ---
@@ -1075,6 +1073,8 @@ HttpTransact::ModifyRequest(State *s)
if (!request.is_target_in_url()) {
s->hdr_info.client_req_is_server_style = true;
}
+ // Make Coverity happy. hostname is non-null iff request.is_target_in_url().
--- End diff --
It's just who we are.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1116: TS-4979: Fix clang-analyzer complaint about poten...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1116
Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/931/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1116: TS-4979: Fix clang-analyzer complaint abou...
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1116#discussion_r83893797
--- Diff: proxy/http/HttpTransact.cc ---
@@ -1075,6 +1073,8 @@ HttpTransact::ModifyRequest(State *s)
if (!request.is_target_in_url()) {
s->hdr_info.client_req_is_server_style = true;
}
+ // Make Coverity happy. hostname is non-null iff request.is_target_in_url().
--- End diff --
Since we're bike shedding, this probably should have said "clang-analyzer". ;-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1116: TS-4979: Fix clang-analyzer complaint abou...
Posted by SolidWallOfCode <gi...@git.apache.org>.
Github user SolidWallOfCode closed the pull request at:
https://github.com/apache/trafficserver/pull/1116
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1116: TS-4979: Fix clang-analyzer complaint about poten...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1116
Linux build *failed*! See https://ci.trafficserver.apache.org/job/Github-Linux/930/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1116: TS-4979: Fix clang-analyzer complaint about poten...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1116
FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1039/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---