You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cxf.apache.org by "Michael Prieß (Created JIRA)" <ji...@apache.org> on 2012/01/27 15:36:15 UTC
[jira] [Created] (CXF-4071) LoggingInterceptors contain parts which
are not nessecary.
LoggingInterceptors contain parts which are not nessecary.
----------------------------------------------------------
Key: CXF-4071
URL: https://issues.apache.org/jira/browse/CXF-4071
Project: CXF
Issue Type: Bug
Components: Core
Affects Versions: 2.5.2
Reporter: Michael Prieß
The LoggingInInterceptor trying to log the Message.RESPONSE_CODE, this is not necessary.
The LoggingOutInterceptor trying to log the HTTP_REQUEST_METHOD, this is not necessary.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CXF-4071) LoggingInterceptors contain parts which
are not nessecary.
Posted by "Michael Prieß (Updated JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Prieß updated CXF-4071:
-------------------------------
Attachment: LoggingInInterceptor.java.patch
LoggingOutInterceptor.java.patch
> LoggingInterceptors contain parts which are not nessecary.
> ----------------------------------------------------------
>
> Key: CXF-4071
> URL: https://issues.apache.org/jira/browse/CXF-4071
> Project: CXF
> Issue Type: Bug
> Components: Core
> Affects Versions: 2.5.2
> Reporter: Michael Prieß
> Assignee: Christian Schneider
> Attachments: LoggingInInterceptor.java.patch, LoggingOutInterceptor.java.patch
>
> Original Estimate: 5m
> Remaining Estimate: 5m
>
> The LoggingInInterceptor trying to log the Message.RESPONSE_CODE, this is not necessary.
> The LoggingOutInterceptor trying to log the HTTP_REQUEST_METHOD, this is not necessary.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CXF-4071) LoggingInterceptors contain parts
which are not nessecary.
Posted by "Christian Schneider (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13194821#comment-13194821 ]
Christian Schneider commented on CXF-4071:
------------------------------------------
@Dan: Sounds like a good idea to use isRequestor
@Michael: Can you change that?
> LoggingInterceptors contain parts which are not nessecary.
> ----------------------------------------------------------
>
> Key: CXF-4071
> URL: https://issues.apache.org/jira/browse/CXF-4071
> Project: CXF
> Issue Type: Bug
> Components: Core
> Affects Versions: 2.5.2
> Reporter: Michael Prieß
> Assignee: Christian Schneider
> Attachments: LoggingInInterceptor.java.patch, LoggingOutInterceptor.java.patch
>
> Original Estimate: 5m
> Remaining Estimate: 5m
>
> The LoggingInInterceptor trying to log the Message.RESPONSE_CODE, this is not necessary.
> The LoggingOutInterceptor trying to log the HTTP_REQUEST_METHOD, this is not necessary.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CXF-4071) LoggingInterceptors contain parts which
are not nessecary.
Posted by "Michael Prieß (Updated JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Prieß updated CXF-4071:
-------------------------------
Attachment: (was: LoggingInInterceptor.java.patch)
> LoggingInterceptors contain parts which are not nessecary.
> ----------------------------------------------------------
>
> Key: CXF-4071
> URL: https://issues.apache.org/jira/browse/CXF-4071
> Project: CXF
> Issue Type: Bug
> Components: Core
> Affects Versions: 2.5.2
> Reporter: Michael Prieß
> Assignee: Christian Schneider
> Attachments: LoggingInInterceptor.java.patch, LoggingOutInterceptor.java.patch
>
> Original Estimate: 5m
> Remaining Estimate: 5m
>
> The LoggingInInterceptor trying to log the Message.RESPONSE_CODE, this is not necessary.
> The LoggingOutInterceptor trying to log the HTTP_REQUEST_METHOD, this is not necessary.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CXF-4071) LoggingInterceptors contain parts which
are not nessecary.
Posted by "Michael Prieß (Updated JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Prieß updated CXF-4071:
-------------------------------
Issue Type: Improvement (was: Bug)
> LoggingInterceptors contain parts which are not nessecary.
> ----------------------------------------------------------
>
> Key: CXF-4071
> URL: https://issues.apache.org/jira/browse/CXF-4071
> Project: CXF
> Issue Type: Improvement
> Components: Core
> Affects Versions: 2.5.2
> Reporter: Michael Prieß
> Assignee: Christian Schneider
> Attachments: LoggingInInterceptor.java.patch, LoggingOutInterceptor.java.patch
>
> Original Estimate: 5m
> Remaining Estimate: 5m
>
> The LoggingInInterceptor trying to log the Message.RESPONSE_CODE, this is not necessary.
> The LoggingOutInterceptor trying to log the HTTP_REQUEST_METHOD, this is not necessary.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (CXF-4071) LoggingInterceptors contain parts
which are not nessecary.
Posted by "Christian Schneider (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Christian Schneider reassigned CXF-4071:
----------------------------------------
Assignee: Christian Schneider
> LoggingInterceptors contain parts which are not nessecary.
> ----------------------------------------------------------
>
> Key: CXF-4071
> URL: https://issues.apache.org/jira/browse/CXF-4071
> Project: CXF
> Issue Type: Bug
> Components: Core
> Affects Versions: 2.5.2
> Reporter: Michael Prieß
> Assignee: Christian Schneider
> Attachments: LoggingInInterceptor.java.patch, LoggingOutInterceptor.java.patch
>
> Original Estimate: 5m
> Remaining Estimate: 5m
>
> The LoggingInInterceptor trying to log the Message.RESPONSE_CODE, this is not necessary.
> The LoggingOutInterceptor trying to log the HTTP_REQUEST_METHOD, this is not necessary.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CXF-4071) LoggingInterceptors contain parts
which are not nessecary.
Posted by "Daniel Kulp (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13194804#comment-13194804 ]
Daniel Kulp commented on CXF-4071:
----------------------------------
These interceptors are also used on the Client side. On the client side, on the incoming message, knowing the response code is important as that can help diagnose what the chains are doing, what the REST server did, etc.... On outgoing, the METHOD is important, especially for REST where the METHOD is an extremely important part about what the request is doing.
I would not remove them. However, it could be put into a MessageUtils.isRequestor(...) block.
> LoggingInterceptors contain parts which are not nessecary.
> ----------------------------------------------------------
>
> Key: CXF-4071
> URL: https://issues.apache.org/jira/browse/CXF-4071
> Project: CXF
> Issue Type: Bug
> Components: Core
> Affects Versions: 2.5.2
> Reporter: Michael Prieß
> Assignee: Christian Schneider
> Attachments: LoggingInInterceptor.java.patch, LoggingOutInterceptor.java.patch
>
> Original Estimate: 5m
> Remaining Estimate: 5m
>
> The LoggingInInterceptor trying to log the Message.RESPONSE_CODE, this is not necessary.
> The LoggingOutInterceptor trying to log the HTTP_REQUEST_METHOD, this is not necessary.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CXF-4071) LoggingInterceptors contain parts
which are not nessecary.
Posted by "Sergey Beryozkin (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13194887#comment-13194887 ]
Sergey Beryozkin commented on CXF-4071:
---------------------------------------
Hi All,
If needed I'm prepared to update the JAX-RS runtime (client/server) for it to set a contextual property
such as "org.apache.cxf.logging.extra" set to true. Logging interceptors can 'identify' the properties which belong to the 'extra' scope and ignore them by default (i.e in the SOAP case). If needed the jaxws endpoints may also set such a property to true. That may help optimize a bit the logging data for WS cases.
But if the response code is already checked as Christian pointed out then may be indeed we can leave the code as is
Cheers
> LoggingInterceptors contain parts which are not nessecary.
> ----------------------------------------------------------
>
> Key: CXF-4071
> URL: https://issues.apache.org/jira/browse/CXF-4071
> Project: CXF
> Issue Type: Improvement
> Components: Core
> Affects Versions: 2.5.2
> Reporter: Michael Prieß
> Assignee: Christian Schneider
> Attachments: LoggingInInterceptor.java.patch, LoggingOutInterceptor.java.patch
>
> Original Estimate: 5m
> Remaining Estimate: 5m
>
> The LoggingInInterceptor trying to log the Message.RESPONSE_CODE, this is not necessary.
> The LoggingOutInterceptor trying to log the HTTP_REQUEST_METHOD, this is not necessary.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CXF-4071) LoggingInterceptors contain parts
which are not nessecary.
Posted by "Michael Prieß (Commented JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13194948#comment-13194948 ]
Michael Prieß commented on CXF-4071:
------------------------------------
Sorry, that I created a lot of trouble.
> LoggingInterceptors contain parts which are not nessecary.
> ----------------------------------------------------------
>
> Key: CXF-4071
> URL: https://issues.apache.org/jira/browse/CXF-4071
> Project: CXF
> Issue Type: Improvement
> Components: Core
> Affects Versions: 2.5.2
> Reporter: Michael Prieß
> Assignee: Christian Schneider
> Attachments: LoggingInInterceptor.java.patch, LoggingOutInterceptor.java.patch
>
> Original Estimate: 5m
> Remaining Estimate: 5m
>
> The LoggingInInterceptor trying to log the Message.RESPONSE_CODE, this is not necessary.
> The LoggingOutInterceptor trying to log the HTTP_REQUEST_METHOD, this is not necessary.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CXF-4071) LoggingInterceptors contain parts
which are not nessecary.
Posted by "Christian Schneider (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13194883#comment-13194883 ]
Christian Schneider commented on CXF-4071:
------------------------------------------
I just looked at the new patch. I think it is not necessary to check witth the isRequestor. The check if e.g. the response code is set is good enough. If the response code is set it makes sense to log it. So I think there is no need to change anything.
Sorry that I did not see this earlier? Do you guys agree? Well if nothing more this at least got Michael to submit his first patch to CXF :-)
> LoggingInterceptors contain parts which are not nessecary.
> ----------------------------------------------------------
>
> Key: CXF-4071
> URL: https://issues.apache.org/jira/browse/CXF-4071
> Project: CXF
> Issue Type: Improvement
> Components: Core
> Affects Versions: 2.5.2
> Reporter: Michael Prieß
> Assignee: Christian Schneider
> Attachments: LoggingInInterceptor.java.patch, LoggingOutInterceptor.java.patch
>
> Original Estimate: 5m
> Remaining Estimate: 5m
>
> The LoggingInInterceptor trying to log the Message.RESPONSE_CODE, this is not necessary.
> The LoggingOutInterceptor trying to log the HTTP_REQUEST_METHOD, this is not necessary.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CXF-4071) LoggingInterceptors contain parts
which are not nessecary.
Posted by "Michael Prieß (Commented JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13194824#comment-13194824 ]
Michael Prieß commented on CXF-4071:
------------------------------------
@Daniel full ack
I provide a patch.
> LoggingInterceptors contain parts which are not nessecary.
> ----------------------------------------------------------
>
> Key: CXF-4071
> URL: https://issues.apache.org/jira/browse/CXF-4071
> Project: CXF
> Issue Type: Bug
> Components: Core
> Affects Versions: 2.5.2
> Reporter: Michael Prieß
> Assignee: Christian Schneider
> Attachments: LoggingInInterceptor.java.patch, LoggingOutInterceptor.java.patch
>
> Original Estimate: 5m
> Remaining Estimate: 5m
>
> The LoggingInInterceptor trying to log the Message.RESPONSE_CODE, this is not necessary.
> The LoggingOutInterceptor trying to log the HTTP_REQUEST_METHOD, this is not necessary.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (CXF-4071) LoggingInterceptors contain parts which
are not nessecary.
Posted by "Michael Prieß (Closed JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Prieß closed CXF-4071.
------------------------------
Resolution: Not A Problem
> LoggingInterceptors contain parts which are not nessecary.
> ----------------------------------------------------------
>
> Key: CXF-4071
> URL: https://issues.apache.org/jira/browse/CXF-4071
> Project: CXF
> Issue Type: Improvement
> Components: Core
> Affects Versions: 2.5.2
> Reporter: Michael Prieß
> Assignee: Christian Schneider
> Attachments: LoggingInInterceptor.java.patch, LoggingOutInterceptor.java.patch
>
> Original Estimate: 5m
> Remaining Estimate: 5m
>
> The LoggingInInterceptor trying to log the Message.RESPONSE_CODE, this is not necessary.
> The LoggingOutInterceptor trying to log the HTTP_REQUEST_METHOD, this is not necessary.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CXF-4071) LoggingInterceptors contain parts
which are not nessecary.
Posted by "Sergey Beryozkin (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13194845#comment-13194845 ]
Sergey Beryozkin commented on CXF-4071:
---------------------------------------
I have to do -1 on dropping the response code too.
For example, see http://cxf.apache.org/docs/jax-rs-oauth.html
it shows clearly 303, etc, we can get 204 and the consumer can be a browser so the useful piece of logging will be lost.
For SOAP you can get 200 & 500.
I suggest to get Logging interceptors to ignore the requests/responses only if a certain property is set and get SOAP interceptors set such a property
> LoggingInterceptors contain parts which are not nessecary.
> ----------------------------------------------------------
>
> Key: CXF-4071
> URL: https://issues.apache.org/jira/browse/CXF-4071
> Project: CXF
> Issue Type: Bug
> Components: Core
> Affects Versions: 2.5.2
> Reporter: Michael Prieß
> Assignee: Christian Schneider
> Attachments: LoggingInInterceptor.java.patch, LoggingOutInterceptor.java.patch
>
> Original Estimate: 5m
> Remaining Estimate: 5m
>
> The LoggingInInterceptor trying to log the Message.RESPONSE_CODE, this is not necessary.
> The LoggingOutInterceptor trying to log the HTTP_REQUEST_METHOD, this is not necessary.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CXF-4071) LoggingInterceptors contain parts
which are not nessecary.
Posted by "Sergey Beryozkin (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13194834#comment-13194834 ]
Sergey Beryozkin commented on CXF-4071:
---------------------------------------
Agreed with Dan re HTTP Method
> LoggingInterceptors contain parts which are not nessecary.
> ----------------------------------------------------------
>
> Key: CXF-4071
> URL: https://issues.apache.org/jira/browse/CXF-4071
> Project: CXF
> Issue Type: Bug
> Components: Core
> Affects Versions: 2.5.2
> Reporter: Michael Prieß
> Assignee: Christian Schneider
> Attachments: LoggingInInterceptor.java.patch, LoggingOutInterceptor.java.patch
>
> Original Estimate: 5m
> Remaining Estimate: 5m
>
> The LoggingInInterceptor trying to log the Message.RESPONSE_CODE, this is not necessary.
> The LoggingOutInterceptor trying to log the HTTP_REQUEST_METHOD, this is not necessary.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CXF-4071) LoggingInterceptors contain parts which
are not nessecary.
Posted by "Michael Prieß (Updated JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Prieß updated CXF-4071:
-------------------------------
Attachment: LoggingInInterceptor.java.patch
LoggingOutInterceptor.java.patch
patches
> LoggingInterceptors contain parts which are not nessecary.
> ----------------------------------------------------------
>
> Key: CXF-4071
> URL: https://issues.apache.org/jira/browse/CXF-4071
> Project: CXF
> Issue Type: Bug
> Components: Core
> Affects Versions: 2.5.2
> Reporter: Michael Prieß
> Attachments: LoggingInInterceptor.java.patch, LoggingOutInterceptor.java.patch
>
>
> The LoggingInInterceptor trying to log the Message.RESPONSE_CODE, this is not necessary.
> The LoggingOutInterceptor trying to log the HTTP_REQUEST_METHOD, this is not necessary.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CXF-4071) LoggingInterceptors contain parts which
are not nessecary.
Posted by "Michael Prieß (Updated JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Prieß updated CXF-4071:
-------------------------------
Attachment: (was: LoggingOutInterceptor.java.patch)
> LoggingInterceptors contain parts which are not nessecary.
> ----------------------------------------------------------
>
> Key: CXF-4071
> URL: https://issues.apache.org/jira/browse/CXF-4071
> Project: CXF
> Issue Type: Bug
> Components: Core
> Affects Versions: 2.5.2
> Reporter: Michael Prieß
> Assignee: Christian Schneider
> Attachments: LoggingInInterceptor.java.patch, LoggingOutInterceptor.java.patch
>
> Original Estimate: 5m
> Remaining Estimate: 5m
>
> The LoggingInInterceptor trying to log the Message.RESPONSE_CODE, this is not necessary.
> The LoggingOutInterceptor trying to log the HTTP_REQUEST_METHOD, this is not necessary.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CXF-4071) LoggingInterceptors contain parts
which are not nessecary.
Posted by "Sergey Beryozkin (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13194908#comment-13194908 ]
Sergey Beryozkin commented on CXF-4071:
---------------------------------------
Ok, after commenting a lot I've read it again, as usual :-).
Michael, sorry, I missed your point from the start.
Seeing the request HTTP method being output by LoggingOutInterceptor on the server side may be still useful for some additional 'context', but I agree it may be redundant, given that LoggingInInterceptor has already showed it.
So scoping it with the isRequestor() as suggested by Dan sounds good.
As for the response code, LoggingInInterceptor (on the client side) needs to show it IMHO, with Christian also saying it's conditional if the response code is set.
So, I'm sorry for a noise :-),
Cheers
> LoggingInterceptors contain parts which are not nessecary.
> ----------------------------------------------------------
>
> Key: CXF-4071
> URL: https://issues.apache.org/jira/browse/CXF-4071
> Project: CXF
> Issue Type: Improvement
> Components: Core
> Affects Versions: 2.5.2
> Reporter: Michael Prieß
> Assignee: Christian Schneider
> Attachments: LoggingInInterceptor.java.patch, LoggingOutInterceptor.java.patch
>
> Original Estimate: 5m
> Remaining Estimate: 5m
>
> The LoggingInInterceptor trying to log the Message.RESPONSE_CODE, this is not necessary.
> The LoggingOutInterceptor trying to log the HTTP_REQUEST_METHOD, this is not necessary.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CXF-4071) LoggingInterceptors contain parts
which are not nessecary.
Posted by "Sergey Beryozkin (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13195126#comment-13195126 ]
Sergey Beryozkin commented on CXF-4071:
---------------------------------------
Dan, Christian - if you reckon it makes sense to optimize LoggingOutInterceptor's server output, please do add isRequestor(); hope we are all in agreement re the response status.
Michael - sorry again if my comments discouraged you :-)
> LoggingInterceptors contain parts which are not nessecary.
> ----------------------------------------------------------
>
> Key: CXF-4071
> URL: https://issues.apache.org/jira/browse/CXF-4071
> Project: CXF
> Issue Type: Improvement
> Components: Core
> Affects Versions: 2.5.2
> Reporter: Michael Prieß
> Assignee: Christian Schneider
> Attachments: LoggingInInterceptor.java.patch, LoggingOutInterceptor.java.patch
>
> Original Estimate: 5m
> Remaining Estimate: 5m
>
> The LoggingInInterceptor trying to log the Message.RESPONSE_CODE, this is not necessary.
> The LoggingOutInterceptor trying to log the HTTP_REQUEST_METHOD, this is not necessary.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (CXF-4071) LoggingInterceptors
contain parts which are not nessecary.
Posted by "Sergey Beryozkin (Issue Comment Edited) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13194835#comment-13194835 ]
Sergey Beryozkin edited comment on CXF-4071 at 1/27/12 3:21 PM:
----------------------------------------------------------------
Even for simple SOAP we can get GETs, it's never redundant to output the request method.
In case of REST we can get the browsers so dropping the method info will lose this info on the server side.
was (Author: sergey_beryozkin):
Even for simple SOAP we can get GETs, it's never redundant to output the request method
> LoggingInterceptors contain parts which are not nessecary.
> ----------------------------------------------------------
>
> Key: CXF-4071
> URL: https://issues.apache.org/jira/browse/CXF-4071
> Project: CXF
> Issue Type: Improvement
> Components: Core
> Affects Versions: 2.5.2
> Reporter: Michael Prieß
> Assignee: Christian Schneider
> Attachments: LoggingInInterceptor.java.patch, LoggingOutInterceptor.java.patch
>
> Original Estimate: 5m
> Remaining Estimate: 5m
>
> The LoggingInInterceptor trying to log the Message.RESPONSE_CODE, this is not necessary.
> The LoggingOutInterceptor trying to log the HTTP_REQUEST_METHOD, this is not necessary.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CXF-4071) LoggingInterceptors contain parts
which are not nessecary.
Posted by "Sergey Beryozkin (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13194835#comment-13194835 ]
Sergey Beryozkin commented on CXF-4071:
---------------------------------------
Even for simple SOAP we can get GETs, it's never redundant to output the request method
> LoggingInterceptors contain parts which are not nessecary.
> ----------------------------------------------------------
>
> Key: CXF-4071
> URL: https://issues.apache.org/jira/browse/CXF-4071
> Project: CXF
> Issue Type: Bug
> Components: Core
> Affects Versions: 2.5.2
> Reporter: Michael Prieß
> Assignee: Christian Schneider
> Attachments: LoggingInInterceptor.java.patch, LoggingOutInterceptor.java.patch
>
> Original Estimate: 5m
> Remaining Estimate: 5m
>
> The LoggingInInterceptor trying to log the Message.RESPONSE_CODE, this is not necessary.
> The LoggingOutInterceptor trying to log the HTTP_REQUEST_METHOD, this is not necessary.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CXF-4071) LoggingInterceptors contain parts which
are not nessecary.
Posted by "Michael Prieß (Updated JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Prieß updated CXF-4071:
-------------------------------
Estimated Complexity: Novice (was: Unknown)
Remaining Estimate: 5m
Original Estimate: 5m
> LoggingInterceptors contain parts which are not nessecary.
> ----------------------------------------------------------
>
> Key: CXF-4071
> URL: https://issues.apache.org/jira/browse/CXF-4071
> Project: CXF
> Issue Type: Bug
> Components: Core
> Affects Versions: 2.5.2
> Reporter: Michael Prieß
> Attachments: LoggingInInterceptor.java.patch, LoggingOutInterceptor.java.patch
>
> Original Estimate: 5m
> Remaining Estimate: 5m
>
> The LoggingInInterceptor trying to log the Message.RESPONSE_CODE, this is not necessary.
> The LoggingOutInterceptor trying to log the HTTP_REQUEST_METHOD, this is not necessary.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira