You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "tanvipenumudy (via GitHub)" <gi...@apache.org> on 2023/03/24 06:42:30 UTC
[GitHub] [ozone] tanvipenumudy opened a new pull request, #4467: HDDS-8270. Measure checkAccess latency for Ozone objects
tanvipenumudy opened a new pull request, #4467:
URL: https://github.com/apache/ozone/pull/4467
## What changes were proposed in this pull request?
Introducing a new OM performance metric for capturing the latency of the `checkAccess` method in the `OmMetadataReader` class. This metric shall be crucial in measuring the time it takes for the security providers that extend support for Ozone ACLs to verify the access permissions granted for a given Ozone object.
This metric could potentially serve as a valuable tool in identifying any performance bottlenecks and improving efficiency.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-8270
## How was this patch tested?
The patch has been tested over a cluster that has the Ozone services running to see what the metric looks like. A sample screenshot of the Prometheus UI has been attached (for reference) capturing `om_performance_metrics_check_access_latency_ns_avg_time` (in nanoseconds):

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] neils-dev commented on a diff in pull request #4467: HDDS-8270. Measure checkAccess latency for Ozone objects
Posted by "neils-dev (via GitHub)" <gi...@apache.org>.
neils-dev commented on code in PR #4467:
URL: https://github.com/apache/ozone/pull/4467#discussion_r1155528481
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OMPerformanceMetrics.java:
##########
@@ -140,4 +142,8 @@ public MutableRate getGetKeyInfoResolveBucketLatencyNs() {
public void setForceContainerCacheRefresh(boolean value) {
forceContainerCacheRefresh.add(value ? 1L : 0L);
}
+
+ public MutableRate getCheckAccessLatencyNs() {
Review Comment:
Thanks @tanvipenumudy for the patch. Not sure about passing the _private_ metric `MutableRate` variable from this class to an external caller. Should just have _getters_ and _setters_ for the private `checkAccessLatencyNs `variable. Can we not structure this so the variable remains hidden and private and just declare a setter for `checkAccessLatencyNs`, such as `public void setCheckAccessLatencyNs(long latencyInNs) `and pass the setter to a _**similar**_ utility function to `captureLatencyNs` that sets the `MutableRate` with the setter?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai merged pull request #4467: HDDS-8270. Measure checkAccess latency for Ozone objects
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai merged PR #4467:
URL: https://github.com/apache/ozone/pull/4467
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] neils-dev commented on a diff in pull request #4467: HDDS-8270. Measure checkAccess latency for Ozone objects
Posted by "neils-dev (via GitHub)" <gi...@apache.org>.
neils-dev commented on code in PR #4467:
URL: https://github.com/apache/ozone/pull/4467#discussion_r1155528481
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OMPerformanceMetrics.java:
##########
@@ -140,4 +142,8 @@ public MutableRate getGetKeyInfoResolveBucketLatencyNs() {
public void setForceContainerCacheRefresh(boolean value) {
forceContainerCacheRefresh.add(value ? 1L : 0L);
}
+
+ public MutableRate getCheckAccessLatencyNs() {
Review Comment:
Thanks @tanvipenumudy for the patch. Not sure about passing the _private_ metric `MutableRate` variable from this class to an external caller. Should just have _getters_ and `setters` for the private `checkAccessLatencyNs `variable. Can we not structure this so the variable remains hidden and private and just declare a setter for `checkAccessLatencyNs`, such as `public void setCheckAccessLatencyNs(long latencyInNs) `and pass the setter to a _**similar**_ utility function to `captureLatencyNs` that sets the `MutableRate` with the setter?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] tanvipenumudy commented on a diff in pull request #4467: HDDS-8270. Measure checkAccess latency for Ozone objects
Posted by "tanvipenumudy (via GitHub)" <gi...@apache.org>.
tanvipenumudy commented on code in PR #4467:
URL: https://github.com/apache/ozone/pull/4467#discussion_r1160001400
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OMPerformanceMetrics.java:
##########
@@ -140,4 +142,8 @@ public MutableRate getGetKeyInfoResolveBucketLatencyNs() {
public void setForceContainerCacheRefresh(boolean value) {
forceContainerCacheRefresh.add(value ? 1L : 0L);
}
+
+ public MutableRate getCheckAccessLatencyNs() {
Review Comment:
Sure @neils-dev, thank you for the review - will be incorporating the aforementioned changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] neils-dev commented on pull request #4467: HDDS-8270. Measure checkAccess latency for Ozone objects
Posted by "neils-dev (via GitHub)" <gi...@apache.org>.
neils-dev commented on PR #4467:
URL: https://github.com/apache/ozone/pull/4467#issuecomment-1520611240
Thanks @tanvipenumudy for the changes. Thanks @adoroszlai for seeing the comments addressed and for merging this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org