[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #5828: server: fix update vm with unconstrained offering

[GitBox <gi...@apache.org>]

sureshanaparti commented on a change in pull request #5828:
URL: https://github.com/apache/cloudstack/pull/5828#discussion_r779399156



##########
File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
##########
@@ -2644,6 +2643,9 @@ private void verifyVmLimits(UserVmVO vmInstance, Map<String, String> details) {
             Map<String, String> customParameters = new HashMap<>();
             customParameters.put(VmDetailConstants.CPU_NUMBER, String.valueOf(newCpu));
             customParameters.put(VmDetailConstants.MEMORY, String.valueOf(newMemory));
+            if (svcOffering.getSpeed() == null) {

Review comment:
       This cond may not be needed, as Unconstrained offering doesn't have CPU speed set and so it's null always. Pls check.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org