You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Anand Mazumdar <ma...@gmail.com> on 2016/03/29 02:19:23 UTC
Review Request 45410: Documented when to invoke `send` using the
scheduler library.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45410/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Bugs: MESOS-4950
https://issues.apache.org/jira/browse/MESOS-4950
Repository: mesos
Description
-------
Trivial change to add a comment to invoke `send` only after
receiving the `connected` callback. If not, all calls would
be dropped while disconnected.
Diffs
-----
include/mesos/v1/scheduler.hpp 765935e97b6c1686ab464a5cf1cf2dfd816f51f1
Diff: https://reviews.apache.org/r/45410/diff/
Testing
-------
make check
Thanks,
Anand Mazumdar
Re: Review Request 45410: Documented when to invoke `send` using the
scheduler library.
Posted by Anand Mazumdar <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45410/
-----------------------------------------------------------
(Updated March 30, 2016, 6:45 p.m.)
Review request for mesos and Vinod Kone.
Changes
-------
Added review comments from r45408 here.
Bugs: MESOS-4950
https://issues.apache.org/jira/browse/MESOS-4950
Repository: mesos
Description
-------
Trivial change to add a comment to invoke `send` only after
receiving the `connected` callback. If not, all calls would
be dropped while disconnected.
Diffs (updated)
-----
include/mesos/v1/scheduler.hpp 765935e97b6c1686ab464a5cf1cf2dfd816f51f1
Diff: https://reviews.apache.org/r/45410/diff/
Testing
-------
make check
Thanks,
Anand Mazumdar
Re: Review Request 45410: Documented when to invoke `send` using the
scheduler library.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45410/#review125983
-----------------------------------------------------------
Ship it!
Oh so you added it here. Cool.
Can you specificy somewhere that the library automatically reconnects with the master after a disconnection?
- Vinod Kone
On March 29, 2016, 12:19 a.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45410/
> -----------------------------------------------------------
>
> (Updated March 29, 2016, 12:19 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-4950
> https://issues.apache.org/jira/browse/MESOS-4950
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Trivial change to add a comment to invoke `send` only after
> receiving the `connected` callback. If not, all calls would
> be dropped while disconnected.
>
>
> Diffs
> -----
>
> include/mesos/v1/scheduler.hpp 765935e97b6c1686ab464a5cf1cf2dfd816f51f1
>
> Diff: https://reviews.apache.org/r/45410/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 45410: Documented when to invoke `send` using the
scheduler library.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45410/#review125843
-----------------------------------------------------------
Patch looks great!
Reviews applied: [45408, 45409, 45410]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On March 29, 2016, 12:19 a.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45410/
> -----------------------------------------------------------
>
> (Updated March 29, 2016, 12:19 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-4950
> https://issues.apache.org/jira/browse/MESOS-4950
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Trivial change to add a comment to invoke `send` only after
> receiving the `connected` callback. If not, all calls would
> be dropped while disconnected.
>
>
> Diffs
> -----
>
> include/mesos/v1/scheduler.hpp 765935e97b6c1686ab464a5cf1cf2dfd816f51f1
>
> Diff: https://reviews.apache.org/r/45410/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>