You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Peter Tran <pt...@pivotal.io> on 2019/06/03 16:16:01 UTC
IntelliJ inspect git hooks
Hi All,
I was wondering if anyone has any git hooks setup to ensure your commit is
not introducing new intelliJ warnings. I was gonna play around with this
but was hoping maybe someone has already solved them problem.
Thank you!
Re: IntelliJ inspect git hooks
Posted by Udo Kohlmeyer <ud...@apache.org>.
Boy scouts.. yeah... @kirk has tried a few times to remind people not to
add to the crazy... but seemingly it just keeps coming back...
So short of, "you've added warnings" and rejecting, this is not going to
be easily solved.
--Udo
On 6/3/19 12:44, Peter Tran wrote:
> @Udo Kohlmeyer <uk...@gmail.com>
>
> Yeah totally agree - make everything better than you found it. Boy scouts
> rule? If we all followed it we'd systematically remove all the warnings
> from the code base (at least files we still touch).
>
>
> On Mon, Jun 3, 2019 at 2:30 PM Udo Kohlmeyer <ud...@apache.org> wrote:
>
>> @Peter, as I understand that we don't want to at least not to add to the
>> existing pain, BUT I don't know if that any plugin or Intellij can
>> determine if it was made worse.
>>
>> I think just cleaning up the warnings should not be too hard... That way
>> it can be simple reasoning if it has been made worse.
>>
>> --Udo
>>
>> On 6/3/19 11:21, Peter Tran wrote:
>>> Thanks Jake
>>>
>>> Is it configurable to warn you if you're adding new warnings? Right now
>>> it's tough to clean up all warnings in a file you touch but at least we
>>> should not be making things worse (at least stop the bleeding so to say)
>>>
>>> On Mon, Jun 3, 2019 at 12:55 PM Jacob Barrett <jb...@pivotal.io>
>> wrote:
>>>> If you’re already using IntelliJ then if you commit with IntelliJ you
>> can
>>>> enable the commit analysis and it will tell you if there are warnings
>>>> before you commit.
>>>>
>>>> -jake
>>>>
>>>>
>>>>> On Jun 3, 2019, at 9:16 AM, Peter Tran <pt...@pivotal.io> wrote:
>>>>>
>>>>> Hi All,
>>>>>
>>>>> I was wondering if anyone has any git hooks setup to ensure your commit
>>>> is
>>>>> not introducing new intelliJ warnings. I was gonna play around with
>> this
>>>>> but was hoping maybe someone has already solved them problem.
>>>>>
>>>>> Thank you!
Re: IntelliJ inspect git hooks
Posted by Peter Tran <pt...@pivotal.io>.
@Udo Kohlmeyer <uk...@gmail.com>
Yeah totally agree - make everything better than you found it. Boy scouts
rule? If we all followed it we'd systematically remove all the warnings
from the code base (at least files we still touch).
On Mon, Jun 3, 2019 at 2:30 PM Udo Kohlmeyer <ud...@apache.org> wrote:
> @Peter, as I understand that we don't want to at least not to add to the
> existing pain, BUT I don't know if that any plugin or Intellij can
> determine if it was made worse.
>
> I think just cleaning up the warnings should not be too hard... That way
> it can be simple reasoning if it has been made worse.
>
> --Udo
>
> On 6/3/19 11:21, Peter Tran wrote:
> > Thanks Jake
> >
> > Is it configurable to warn you if you're adding new warnings? Right now
> > it's tough to clean up all warnings in a file you touch but at least we
> > should not be making things worse (at least stop the bleeding so to say)
> >
> > On Mon, Jun 3, 2019 at 12:55 PM Jacob Barrett <jb...@pivotal.io>
> wrote:
> >
> >> If you’re already using IntelliJ then if you commit with IntelliJ you
> can
> >> enable the commit analysis and it will tell you if there are warnings
> >> before you commit.
> >>
> >> -jake
> >>
> >>
> >>> On Jun 3, 2019, at 9:16 AM, Peter Tran <pt...@pivotal.io> wrote:
> >>>
> >>> Hi All,
> >>>
> >>> I was wondering if anyone has any git hooks setup to ensure your commit
> >> is
> >>> not introducing new intelliJ warnings. I was gonna play around with
> this
> >>> but was hoping maybe someone has already solved them problem.
> >>>
> >>> Thank you!
>
Re: IntelliJ inspect git hooks
Posted by Udo Kohlmeyer <ud...@apache.org>.
@Peter, as I understand that we don't want to at least not to add to the
existing pain, BUT I don't know if that any plugin or Intellij can
determine if it was made worse.
I think just cleaning up the warnings should not be too hard... That way
it can be simple reasoning if it has been made worse.
--Udo
On 6/3/19 11:21, Peter Tran wrote:
> Thanks Jake
>
> Is it configurable to warn you if you're adding new warnings? Right now
> it's tough to clean up all warnings in a file you touch but at least we
> should not be making things worse (at least stop the bleeding so to say)
>
> On Mon, Jun 3, 2019 at 12:55 PM Jacob Barrett <jb...@pivotal.io> wrote:
>
>> If you’re already using IntelliJ then if you commit with IntelliJ you can
>> enable the commit analysis and it will tell you if there are warnings
>> before you commit.
>>
>> -jake
>>
>>
>>> On Jun 3, 2019, at 9:16 AM, Peter Tran <pt...@pivotal.io> wrote:
>>>
>>> Hi All,
>>>
>>> I was wondering if anyone has any git hooks setup to ensure your commit
>> is
>>> not introducing new intelliJ warnings. I was gonna play around with this
>>> but was hoping maybe someone has already solved them problem.
>>>
>>> Thank you!
Re: IntelliJ inspect git hooks
Posted by Jacob Barrett <jb...@pivotal.io>.
I thought it was just analyzing the diff section but maybe not. I haven’t used it much with geode because of all the noise, even in a small diff. That is one reason I clean up the files first before starting my work.
-jake
> On Jun 3, 2019, at 11:21 AM, Peter Tran <pt...@pivotal.io> wrote:
>
> Thanks Jake
>
> Is it configurable to warn you if you're adding new warnings? Right now
> it's tough to clean up all warnings in a file you touch but at least we
> should not be making things worse (at least stop the bleeding so to say)
>
>> On Mon, Jun 3, 2019 at 12:55 PM Jacob Barrett <jb...@pivotal.io> wrote:
>>
>> If you’re already using IntelliJ then if you commit with IntelliJ you can
>> enable the commit analysis and it will tell you if there are warnings
>> before you commit.
>>
>> -jake
>>
>>
>>> On Jun 3, 2019, at 9:16 AM, Peter Tran <pt...@pivotal.io> wrote:
>>>
>>> Hi All,
>>>
>>> I was wondering if anyone has any git hooks setup to ensure your commit
>> is
>>> not introducing new intelliJ warnings. I was gonna play around with this
>>> but was hoping maybe someone has already solved them problem.
>>>
>>> Thank you!
>>
Re: IntelliJ inspect git hooks
Posted by Peter Tran <pt...@pivotal.io>.
Thanks Jake
Is it configurable to warn you if you're adding new warnings? Right now
it's tough to clean up all warnings in a file you touch but at least we
should not be making things worse (at least stop the bleeding so to say)
On Mon, Jun 3, 2019 at 12:55 PM Jacob Barrett <jb...@pivotal.io> wrote:
> If you’re already using IntelliJ then if you commit with IntelliJ you can
> enable the commit analysis and it will tell you if there are warnings
> before you commit.
>
> -jake
>
>
> > On Jun 3, 2019, at 9:16 AM, Peter Tran <pt...@pivotal.io> wrote:
> >
> > Hi All,
> >
> > I was wondering if anyone has any git hooks setup to ensure your commit
> is
> > not introducing new intelliJ warnings. I was gonna play around with this
> > but was hoping maybe someone has already solved them problem.
> >
> > Thank you!
>
Re: IntelliJ inspect git hooks
Posted by Jacob Barrett <jb...@pivotal.io>.
If you’re already using IntelliJ then if you commit with IntelliJ you can enable the commit analysis and it will tell you if there are warnings before you commit.
-jake
> On Jun 3, 2019, at 9:16 AM, Peter Tran <pt...@pivotal.io> wrote:
>
> Hi All,
>
> I was wondering if anyone has any git hooks setup to ensure your commit is
> not introducing new intelliJ warnings. I was gonna play around with this
> but was hoping maybe someone has already solved them problem.
>
> Thank you!