You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/09/22 02:27:43 UTC
[GitHub] [skywalking] kezhenxu94 opened a new issue #7762: [Feature] set instance properties in json format: `agent.instance_properties_json`
kezhenxu94 opened a new issue #7762:
URL: https://github.com/apache/skywalking/issues/7762
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
> I find some configurations are in configurations.md , but not in the agent.config , such as ```agent.trace_segment_ref_limit_per_span``` 、```agent.instance_properties[key]=value``` . Otherwise , the configuration ```plugin.dubbo.consumer_provider_length_threshold ``` in the agent.config is not the same as ```plugin.dubbo.provider_arguments_length_threshold``` in the configurations.md.
@dashanji can you open a pull request to fix this? For `agent.instance_properties[xxx]`, I think we also need to migrate to the format of `agent.instance_properties_json={}`. `plugin.dubbo.consumer_provider_length_threshold` should be typo of `plugin.dubbo.consumer_length_threshold`
_Originally posted by @kezhenxu94 in https://github.com/apache/skywalking/issues/7470#issuecomment-922471256_
### Use case
For containerized scenarios, we should be able to set the `agent.instance_properties` easily via environment variables, instead of modifying the config file.
### Related issues
https://github.com/apache/skywalking/pull/7470#issuecomment-922471256
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on issue #7762: [Feature] set instance properties in json format: `agent.instance_properties_json`
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on issue #7762:
URL: https://github.com/apache/skywalking/issues/7762#issuecomment-924530983
Anyone who wants to take this, please reply and I can assign.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] JaredTan95 closed issue #7762: [Feature] set instance properties in json format: `agent.instance_properties_json`
Posted by GitBox <gi...@apache.org>.
JaredTan95 closed issue #7762:
URL: https://github.com/apache/skywalking/issues/7762
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] JaredTan95 commented on issue #7762: [Feature] set instance properties in json format: `agent.instance_properties_json`
Posted by GitBox <gi...@apache.org>.
JaredTan95 commented on issue #7762:
URL: https://github.com/apache/skywalking/issues/7762#issuecomment-962588686
https://github.com/apache/skywalking-java/pull/67 supported
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] deepto98 commented on issue #7762: [Feature] set instance properties in json format: `agent.instance_properties_json`
Posted by GitBox <gi...@apache.org>.
deepto98 commented on issue #7762:
URL: https://github.com/apache/skywalking/issues/7762#issuecomment-934100782
@kezhenxu94 Hi, I would like to take this up, can you please assign it to me? Since I am new to the project, can you also please give a bit more context about the task, and the files which I should start looking at?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on issue #7762: [Feature] set instance properties in json format: `agent.instance_properties_json`
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on issue #7762:
URL: https://github.com/apache/skywalking/issues/7762#issuecomment-934218706
> @kezhenxu94 Hi, I would like to take this up, can you please assign it to me? Since I am new to the project, can you also please give a bit more context about the task, and the files which I should start looking at?
>
>
Hi @deepto98 , thanks for the interest, the rationale behind this task is that, for containerized scenarios, the style of `agent.instance_properties[xxx]=xxx` is hard (if not impossible) to modify, using json style like `agent.instance_properties_json={xxx:yyy}`, the users can modify via environment variables.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org