You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2020/01/03 10:41:33 UTC

[GitHub] [maven-checkstyle-plugin] eolivelli commented on issue #17: [MCHECKSTYLE-385] rework code to use a Violation.java class.

eolivelli commented on issue #17: [MCHECKSTYLE-385] rework code to use a Violation.java class.
URL: https://github.com/apache/maven-checkstyle-plugin/pull/17#issuecomment-570536075
 
 
   @elharo 
   Thank you for pointing every nits, I think it that the patch can be accepted even in case of this little nits.
   
   as this patch needs a rebase  @bmhm  can you please fix all of those points ?
   
   the point about making the class immutable is interesting, it is worth to consider.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services