You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/07/13 14:29:42 UTC

[GitHub] [beam] chamikaramj commented on a change in pull request #15129: [BEAM-12582] Adding jar packages only to Java environments

chamikaramj commented on a change in pull request #15129:
URL: https://github.com/apache/beam/pull/15129#discussion_r668815180



##########
File path: sdks/python/apache_beam/runners/portability/stager.py
##########
@@ -476,25 +466,71 @@ def _is_remote_path(path):
     return path.find('://') != -1
 
   @staticmethod
-  def _create_jar_packages(jar_packages, temp_dir):
+  def append_jar_packages_to_java_env(proto_pipeline, options, temp_dir=None):
+    """Append a list of jar packages to Docker Java SDK Environment.

Review comment:
       So jar_packages is still needed ? Is this only for testing ?
   In production, users will get Java dependencies from CLASSPATH of the expansion service, right ? I wonder if we can migrate existing tests to that path as well and remove this code.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org