You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Jesse Glick (JIRA)" <ji...@codehaus.org> on 2010/11/23 23:34:03 UTC
[jira] Created: (MNG-4911) ArtifactVersion.parseVersion should not
exist (forces impls to be mutable)
ArtifactVersion.parseVersion should not exist (forces impls to be mutable)
--------------------------------------------------------------------------
Key: MNG-4911
URL: http://jira.codehaus.org/browse/MNG-4911
Project: Maven 2 & 3
Issue Type: Bug
Affects Versions: 3.0
Reporter: Jesse Glick
Priority: Minor
It looks like a design flaw that {{ArtifactVersion.parseVersion}} exists; this should just be a private method in {{DefaultArtifactVersion}}, or simply inlined into its constructor, so that versions are immutable as one might expect. Can submit patch if interested.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MNG-4911) ArtifactVersion.parseVersion should not
exist (forces impls to be mutable)
Posted by "Jesse Glick (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-4911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jesse Glick updated MNG-4911:
-----------------------------
Attachment: ArtifactVersion-parseVersion.diff
Might as well attach the patch now.
BTW is it preferred to send pull requests to https://github.com/apache/maven-3 ? Would be a bit more convenient.
> ArtifactVersion.parseVersion should not exist (forces impls to be mutable)
> --------------------------------------------------------------------------
>
> Key: MNG-4911
> URL: http://jira.codehaus.org/browse/MNG-4911
> Project: Maven 2 & 3
> Issue Type: Bug
> Affects Versions: 3.0
> Reporter: Jesse Glick
> Priority: Minor
> Attachments: ArtifactVersion-parseVersion.diff
>
>
> It looks like a design flaw that {{ArtifactVersion.parseVersion}} exists; this should just be a private method in {{DefaultArtifactVersion}}, or simply inlined into its constructor, so that versions are immutable as one might expect. Can submit patch if interested.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira