You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by GitBox <gi...@apache.org> on 2020/06/18 12:54:20 UTC
[GitHub] [incubator-daffodil] jw3 opened a new pull request #388: Scalafix ProcedureSyntax
jw3 opened a new pull request #388:
URL: https://github.com/apache/incubator-daffodil/pull/388
Use Scalafix `ProcedureSyntax` rule to fix the deprecated procedure syntax usage.
DAFFODIL-1673
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-daffodil] mbeckerle commented on pull request #388: Scalafix ProcedureSyntax
Posted by GitBox <gi...@apache.org>.
mbeckerle commented on pull request #388:
URL: https://github.com/apache/incubator-daffodil/pull/388#issuecomment-646000121
Once we incorporate this fix, are there compiler options that we can put into build.sbt to insure we don't end up adding the obsolete construct back again?
I'd like at least a warning if we add this syntax back.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-daffodil] jw3 commented on pull request #388: Scalafix ProcedureSyntax
Posted by GitBox <gi...@apache.org>.
jw3 commented on pull request #388:
URL: https://github.com/apache/incubator-daffodil/pull/388#issuecomment-646064513
Eh, I see it skipped some integration tests too....
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-daffodil] jw3 commented on pull request #388: Scalafix ProcedureSyntax
Posted by GitBox <gi...@apache.org>.
jw3 commented on pull request #388:
URL: https://github.com/apache/incubator-daffodil/pull/388#issuecomment-646101061
It might have been easier for this task, given the complex layout of this project, to just specify the root directory rather than trying to use sbt project mappings
`sbt "scalafix ProcedureSyntax -f /home/path/to/incubator-daffodil"`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-daffodil] stevedlawrence merged pull request #388: Scalafix ProcedureSyntax
Posted by GitBox <gi...@apache.org>.
stevedlawrence merged pull request #388:
URL: https://github.com/apache/incubator-daffodil/pull/388
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-daffodil] jw3 commented on pull request #388: Scalafix ProcedureSyntax
Posted by GitBox <gi...@apache.org>.
jw3 commented on pull request #388:
URL: https://github.com/apache/incubator-daffodil/pull/388#issuecomment-646015309
It looks like this syntax is deprecated by default starting in 2.13., however for pre 2.13 we would have to use the `-Xfuture` flag (which was noted in jira).
I just tested with `-Xfuture` locally in both this PR branch and master and get expected behavior
- compile fails in master
- compile succeeds in PR branch
- compile fails in PR branch if procedure syntax is used
Will add that option in another commit on this PR.
Offhand I am not sure what else -Xfuture could impact...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-daffodil] jw3 commented on pull request #388: Scalafix ProcedureSyntax
Posted by GitBox <gi...@apache.org>.
jw3 commented on pull request #388:
URL: https://github.com/apache/incubator-daffodil/pull/388#issuecomment-646054081
That looks better, had to qualify test to have scalafix rewrite them
`sbt test:"scalafix ProcedureSyntax"`
That added a lot of changes, moving the total (5194) more inline with what was noted in jira (3476).
Tests pass locally with Xfuture, still getting CI failures though. Thoughts?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-daffodil] jw3 commented on pull request #388: Scalafix ProcedureSyntax
Posted by GitBox <gi...@apache.org>.
jw3 commented on pull request #388:
URL: https://github.com/apache/incubator-daffodil/pull/388#issuecomment-646034718
Looking into the failures. It appears Scalafix skipped rewriting tests, causing failed compilation when running tests + Xfuture.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-daffodil] stevedlawrence commented on pull request #388: Scalafix ProcedureSyntax
Posted by GitBox <gi...@apache.org>.
stevedlawrence commented on pull request #388:
URL: https://github.com/apache/incubator-daffodil/pull/388#issuecomment-646016837
Based on https://github.com/scala/scala/pull/3076/, it looks like the ``-Xfuture`` scalacOption enables a check for this. Not sure what other checks this flag enables, but it would probably be a good goal to enable that flag and fix whatever issues show up.
Based on this change https://github.com/scala/scala/pull/6325, it looks like scala 2.13 (which we don't support yet) changes it to the ``-Xsource:2.14`` flag. Scala 2.13 has been out for about a year, so it might be worth considering upgrading to that as well at some point.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org