You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by mo...@apache.org on 2021/11/12 02:37:57 UTC
[incubator-doris] branch master updated: [BUG] fix streaming_preagg
dcheck cause be down (#6873)
This is an automated email from the ASF dual-hosted git repository.
morningman pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-doris.git
The following commit(s) were added to refs/heads/master by this push:
new 6674af6 [BUG] fix streaming_preagg dcheck cause be down (#6873)
6674af6 is described below
commit 6674af6001f66163e2b2b19b86f15874accdccd3
Author: dh-cloud <60...@users.noreply.github.com>
AuthorDate: Fri Nov 12 10:37:46 2021 +0800
[BUG] fix streaming_preagg dcheck cause be down (#6873)
in debug mode，query memory not enough, may cause be down
fe set useStreamingPreagg true, but be function CreateHashPartitions check is_streaming_preagg_ should false.
then casue core dump.
```
*** Check failure stack trace: ***
@ 0x2aa48ad google::LogMessage::Fail()
@ 0x2aa6734 google::LogMessage::SendToLog()
@ 0x2aa43d4 google::LogMessage::Flush()
@ 0x2aa7169 google::LogMessageFatal::~LogMessageFatal()
@ 0x24703be doris::PartitionedAggregationNode::CreateHashPartitions()
@ 0x2468fd6 doris::PartitionedAggregationNode::open()
@ 0x1e3b153 doris::PlanFragmentExecutor::open_internal()
@ 0x1e3af4b doris::PlanFragmentExecutor::open()
@ 0x1d81b92 doris::FragmentExecState::execute()
@ 0x1d840f7 doris::FragmentMgr::_exec_actual()
```
we should remove DCHECK(!is_streaming_preagg_)
---
be/src/exec/partitioned_aggregation_node.cc | 1 -
1 file changed, 1 deletion(-)
diff --git a/be/src/exec/partitioned_aggregation_node.cc b/be/src/exec/partitioned_aggregation_node.cc
index 088a1f2..b2d9db1 100644
--- a/be/src/exec/partitioned_aggregation_node.cc
+++ b/be/src/exec/partitioned_aggregation_node.cc
@@ -1146,7 +1146,6 @@ Status PartitionedAggregationNode::CreateHashPartitions(int level, int single_pa
RETURN_IF_ERROR(partition->InitHashTable(&got_memory));
// Spill the partition if we cannot create a hash table for a merge aggregation.
if (UNLIKELY(!got_memory)) {
- DCHECK(!is_streaming_preagg_) << "Preagg reserves enough memory for hash tables";
// If we're repartitioning, we will be writing aggregated rows first.
RETURN_IF_ERROR(partition->Spill(level > 0));
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org