You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Jaimin Jetly <ja...@hortonworks.com> on 2015/05/01 01:05:23 UTC

Review Request 33734: Create Widget: Integrate creating widgets comprising of host component metrics

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33734/
-----------------------------------------------------------

Review request for Ambari, Srimanth Gunturi, Xi Wang, and Yusaku Sako.


Bugs: AMBARI-10878
    https://issues.apache.org/jira/browse/AMBARI-10878


Repository: ambari


Description
-------

Active resourceManager and Active NameNode component widgets are the supported widgets with the host component level metrics and this ticket will supports the functionality for creating these widgets.

Also verified that the work also supports Edit widget and clone widget functionality for the widgets that comprises of host component metrics


Diffs
-----

  ambari-web/app/controllers/main/service/widgets/create/wizard_controller.js 263f8d8 
  ambari-web/app/mixins/common/widgets/widget_mixin.js 23f3c9f 
  ambari-web/app/models/service/yarn.js 0c38d89 
  ambari-web/app/views/main/service/widgets/create/expression_view.js d311403 

Diff: https://reviews.apache.org/r/33734/diff/


Testing
-------

tested patch on a cluster.
verified that all unit tests passess


Thanks,

Jaimin Jetly


Re: Review Request 33734: Create Widget: Integrate creating widgets comprising of host component metrics

Posted by Xi Wang <xw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33734/#review82222
-----------------------------------------------------------

Ship it!


Ship It!

- Xi Wang


On April 30, 2015, 4:16 p.m., Jaimin Jetly wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33734/
> -----------------------------------------------------------
> 
> (Updated April 30, 2015, 4:16 p.m.)
> 
> 
> Review request for Ambari, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-10878
>     https://issues.apache.org/jira/browse/AMBARI-10878
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Active resourceManager and Active NameNode component widgets are the supported widgets with the host component level metrics and this ticket will supports the functionality for creating these widgets.
> 
> Also verified that the work also supports Edit widget and clone widget functionality for the widgets that comprises of host component metrics
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/controllers/main/service/widgets/create/wizard_controller.js 263f8d8 
>   ambari-web/app/mixins/common/widgets/widget_mixin.js 23f3c9f 
>   ambari-web/app/models/service/yarn.js 0c38d89 
>   ambari-web/app/views/main/service/widgets/create/expression_view.js d311403 
> 
> Diff: https://reviews.apache.org/r/33734/diff/
> 
> 
> Testing
> -------
> 
> tested patch on a cluster.
> verified that all unit tests passess
> 
> 
>   5970 tests complete (11 seconds)
>   79 tests pending
> 
> 
> Thanks,
> 
> Jaimin Jetly
> 
>


Re: Review Request 33734: Create Widget: Integrate creating widgets comprising of host component metrics

Posted by Jaimin Jetly <ja...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33734/
-----------------------------------------------------------

(Updated April 30, 2015, 11:16 p.m.)


Review request for Ambari, Srimanth Gunturi, Xi Wang, and Yusaku Sako.


Bugs: AMBARI-10878
    https://issues.apache.org/jira/browse/AMBARI-10878


Repository: ambari


Description
-------

Active resourceManager and Active NameNode component widgets are the supported widgets with the host component level metrics and this ticket will supports the functionality for creating these widgets.

Also verified that the work also supports Edit widget and clone widget functionality for the widgets that comprises of host component metrics


Diffs
-----

  ambari-web/app/controllers/main/service/widgets/create/wizard_controller.js 263f8d8 
  ambari-web/app/mixins/common/widgets/widget_mixin.js 23f3c9f 
  ambari-web/app/models/service/yarn.js 0c38d89 
  ambari-web/app/views/main/service/widgets/create/expression_view.js d311403 

Diff: https://reviews.apache.org/r/33734/diff/


Testing (updated)
-------

tested patch on a cluster.
verified that all unit tests passess


  5970 tests complete (11 seconds)
  79 tests pending


Thanks,

Jaimin Jetly