You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ant.apache.org by Craeg K Strong <cs...@arielpartners.com> on 2002/05/16 06:20:21 UTC
[PATCH] tests, documentation, and code fixes for
Hello:
Based on the advice of Erik Hatcher and dIon Gillard, attached please
find my revised set of patches for <xmlcatalog>. What is the difference?
This patch set includes only fixes, docs, and tests. I left out the
code that adds support for external catalog files.
Since the additional feature (support for external catalogs) depends on
these fixes and docs anyway, I am happy to adopt this more "phased"
approach. When these fixes get landed, we can talk about what would be
an appropriate time to introduce <catalogfiles>.
Here is a manifest for the contents of the zip file:
DOCS
[ ant-catalog-changes/docs/manual/CoreTasks/style-html.patch ]
Added more info about use of <xmlcatalog> for <xslt>/<style> task
[ ant-catalog-changes/docs/manual/CoreTypes/xmlcatalog-html.patch ]
Added full explanation of resolution algorithm, more examples, added link to
OASIS standard on which this is based, etc.
[ ant-catalog-changes/docs/manual/OptionalTasks/xmlvalidate-html.patch ]
Added more info about use of <xmlcatalog> for <xmlvalidate> task
TESTS
[ ant-catalog-changes/src/etc/testcases/taskdefs/optional/xmlvalidate-xml.patch ]
Added testcase for double-nested <xmlcatalog> instance
[
ant-catalog-changes/src/testcases/org/apache/tools/ant/taskdefs/optional/XmlValidateTest-java.patch
]
Added code for testcase for double-nested <xmlcatalog> instance
[ ant-catalog-changes/src/testcases/org/apache/tools/ant/types/XMLCatalogTest.java ]
Full suite of unit tests for <xmlcatalog>
CODE
[ ant-catalog-changes/src/main/org/apache/tools/ant/types/XMLCatalog-java.patch ]
Refactored code, added comments, added check for circular references
[
ant-catalog-changes/src/main/org/apache/tools/ant/taskdefs/optional/TraXLiaison-java.patch
]
Added capability to set a URIResolver as well as an EntityResolver
[
ant-catalog-changes/src/main/org/apache/tools/ant/taskdefs/XSLTProcess-java.patch ]
Adds <xmlcatalog> as a URIResolver as well as an EntityResolver if present
That's it. Please let me know if you need anything more. Thanks,
--Craeg
Re: [PATCH] tests, documentation, and code fixes for
Posted by Erik Hatcher <ja...@ehatchersolutions.com>.
I just meant that instead of many patch files, roll them all up into a
single patch file that is based from the root of jakarta-ant instead of
based from each subdirectory. Make sense?
Let me know how the newly added stuff is working for you. My first commit
broke things, but I quickly fixed it.
Erik
----- Original Message -----
From: "Craeg K Strong" <cs...@arielpartners.com>
To: "Ant Developers List" <an...@jakarta.apache.org>
Sent: Friday, May 24, 2002 2:37 PM
Subject: Re: [PATCH] tests, documentation, and code fixes for <xmlcatalog>
> Hum. Do you mean:
>
> jakarta-ant/docs/manual/CoreTasks/style-html.patch
>
> instead of
>
> ant-catalog-changes/docs/manual/CoreTasks/style-html.patch
>
> So you can unzip directly into your CVS sandbox?
>
> --Craeg, a bit caffeine deprived....
>
>
> Erik Hatcher wrote:
> > Craeg,
> >
> > I'm getting ready to apply your patches - thanks!. In the future, it
would
> > be easier to apply if you sent a single patch file (with new files
attached
> > separately too) based from the root of our CVS tree.
> >
> > Erik
> >
> >
> > ----- Original Message -----
> > From: "Craeg K Strong" <cs...@arielpartners.com>
> > To: <an...@jakarta.apache.org>
> > Sent: Thursday, May 16, 2002 12:20 AM
> > Subject: [PATCH] tests, documentation, and code fixes for <xmlcatalog>
> >
> >
> >>Hello:
> >>
> >>Based on the advice of Erik Hatcher and dIon Gillard, attached please
> >>find my revised set of patches for <xmlcatalog>. What is the
difference?
> >>This patch set includes only fixes, docs, and tests. I left out the
> >>code that adds support for external catalog files.
> >>
> >>Since the additional feature (support for external catalogs) depends on
> >>these fixes and docs anyway, I am happy to adopt this more "phased"
> >>approach. When these fixes get landed, we can talk about what would be
> >>an appropriate time to introduce <catalogfiles>.
> >>
> >>Here is a manifest for the contents of the zip file:
> >>
> >>DOCS
> >>
> >>[ ant-catalog-changes/docs/manual/CoreTasks/style-html.patch ]
> >>Added more info about use of <xmlcatalog> for <xslt>/<style> task
> >>
> >>[ ant-catalog-changes/docs/manual/CoreTypes/xmlcatalog-html.patch ]
> >>Added full explanation of resolution algorithm, more examples, added
link
> >
> > to
> >
> >>OASIS standard on which this is based, etc.
> >>
> >>[ ant-catalog-changes/docs/manual/OptionalTasks/xmlvalidate-html.patch ]
> >>Added more info about use of <xmlcatalog> for <xmlvalidate> task
> >>
> >>TESTS
> >>
> >>[
> >
> >
ant-catalog-changes/src/etc/testcases/taskdefs/optional/xmlvalidate-xml.patc
> > h ]
> >
> >>Added testcase for double-nested <xmlcatalog> instance
> >>
> >>[
> >>
> >
> >
ant-catalog-changes/src/testcases/org/apache/tools/ant/taskdefs/optional/Xml
> > ValidateTest-java.patch
> >
> >>]
> >>Added code for testcase for double-nested <xmlcatalog> instance
> >>
> >>[
> >
> >
ant-catalog-changes/src/testcases/org/apache/tools/ant/types/XMLCatalogTest.
> > java ]
> >
> >>Full suite of unit tests for <xmlcatalog>
> >>
> >>CODE
> >>
> >>[
> >
> >
ant-catalog-changes/src/main/org/apache/tools/ant/types/XMLCatalog-java.patc
> > h ]
> >
> >>Refactored code, added comments, added check for circular references
> >>
> >>[
> >>
> >
> >
ant-catalog-changes/src/main/org/apache/tools/ant/taskdefs/optional/TraXLiai
> > son-java.patch
> >
> >>]
> >>Added capability to set a URIResolver as well as an EntityResolver
> >>
> >>[
> >>
> >
> >
ant-catalog-changes/src/main/org/apache/tools/ant/taskdefs/XSLTProcess-java.
> > patch ]
> >
> >>Adds <xmlcatalog> as a URIResolver as well as an EntityResolver if
present
> >>
> >>
> >>That's it. Please let me know if you need anything more. Thanks,
> >>
> >>--Craeg
> >>
> >
> >
> >
>
> --------------------------------------------------------------------------
--
> > ----
> >
> >
> >
> >>--
> >>To unsubscribe, e-mail:
<ma...@jakarta.apache.org>
> >>For additional commands, e-mail:
<ma...@jakarta.apache.org>
> >
> >
> >
> > --
> > To unsubscribe, e-mail:
<ma...@jakarta.apache.org>
> > For additional commands, e-mail:
<ma...@jakarta.apache.org>
> >
>
>
> --
> Craeg K Strong, General Partner
> Ariel Partners LLC
> http://www.arielpartners.com
> voice 781-647-2425
> fax 781-647-9690
>
> NOTICE: This message is for the sole use of the intended recipient(s)
> and may contain confidential and privileged information. Any review,
> retransmission, dissemination or other use of, or taking of any action
> in reliance upon, this information by persons or entities other than
> the intended recipient is prohibited. If you are not the intended
> recipient, please contact the sender by reply email and destroy all
> copies -- including electronic copies -- of the original message.
>
>
> --
> To unsubscribe, e-mail: <ma...@jakarta.apache.org>
> For additional commands, e-mail: <ma...@jakarta.apache.org>
>
>
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [PATCH] tests, documentation, and code fixes for
Posted by Craeg K Strong <cs...@arielpartners.com>.
Hum. Do you mean:
jakarta-ant/docs/manual/CoreTasks/style-html.patch
instead of
ant-catalog-changes/docs/manual/CoreTasks/style-html.patch
So you can unzip directly into your CVS sandbox?
--Craeg, a bit caffeine deprived....
Erik Hatcher wrote:
> Craeg,
>
> I'm getting ready to apply your patches - thanks!. In the future, it would
> be easier to apply if you sent a single patch file (with new files attached
> separately too) based from the root of our CVS tree.
>
> Erik
>
>
> ----- Original Message -----
> From: "Craeg K Strong" <cs...@arielpartners.com>
> To: <an...@jakarta.apache.org>
> Sent: Thursday, May 16, 2002 12:20 AM
> Subject: [PATCH] tests, documentation, and code fixes for <xmlcatalog>
>
>
>>Hello:
>>
>>Based on the advice of Erik Hatcher and dIon Gillard, attached please
>>find my revised set of patches for <xmlcatalog>. What is the difference?
>>This patch set includes only fixes, docs, and tests. I left out the
>>code that adds support for external catalog files.
>>
>>Since the additional feature (support for external catalogs) depends on
>>these fixes and docs anyway, I am happy to adopt this more "phased"
>>approach. When these fixes get landed, we can talk about what would be
>>an appropriate time to introduce <catalogfiles>.
>>
>>Here is a manifest for the contents of the zip file:
>>
>>DOCS
>>
>>[ ant-catalog-changes/docs/manual/CoreTasks/style-html.patch ]
>>Added more info about use of <xmlcatalog> for <xslt>/<style> task
>>
>>[ ant-catalog-changes/docs/manual/CoreTypes/xmlcatalog-html.patch ]
>>Added full explanation of resolution algorithm, more examples, added link
>
> to
>
>>OASIS standard on which this is based, etc.
>>
>>[ ant-catalog-changes/docs/manual/OptionalTasks/xmlvalidate-html.patch ]
>>Added more info about use of <xmlcatalog> for <xmlvalidate> task
>>
>>TESTS
>>
>>[
>
> ant-catalog-changes/src/etc/testcases/taskdefs/optional/xmlvalidate-xml.patc
> h ]
>
>>Added testcase for double-nested <xmlcatalog> instance
>>
>>[
>>
>
> ant-catalog-changes/src/testcases/org/apache/tools/ant/taskdefs/optional/Xml
> ValidateTest-java.patch
>
>>]
>>Added code for testcase for double-nested <xmlcatalog> instance
>>
>>[
>
> ant-catalog-changes/src/testcases/org/apache/tools/ant/types/XMLCatalogTest.
> java ]
>
>>Full suite of unit tests for <xmlcatalog>
>>
>>CODE
>>
>>[
>
> ant-catalog-changes/src/main/org/apache/tools/ant/types/XMLCatalog-java.patc
> h ]
>
>>Refactored code, added comments, added check for circular references
>>
>>[
>>
>
> ant-catalog-changes/src/main/org/apache/tools/ant/taskdefs/optional/TraXLiai
> son-java.patch
>
>>]
>>Added capability to set a URIResolver as well as an EntityResolver
>>
>>[
>>
>
> ant-catalog-changes/src/main/org/apache/tools/ant/taskdefs/XSLTProcess-java.
> patch ]
>
>>Adds <xmlcatalog> as a URIResolver as well as an EntityResolver if present
>>
>>
>>That's it. Please let me know if you need anything more. Thanks,
>>
>>--Craeg
>>
>
>
>
> ----------------------------------------------------------------------------
> ----
>
>
>
>>--
>>To unsubscribe, e-mail: <ma...@jakarta.apache.org>
>>For additional commands, e-mail: <ma...@jakarta.apache.org>
>
>
>
> --
> To unsubscribe, e-mail: <ma...@jakarta.apache.org>
> For additional commands, e-mail: <ma...@jakarta.apache.org>
>
--
Craeg K Strong, General Partner
Ariel Partners LLC
http://www.arielpartners.com
voice 781-647-2425
fax 781-647-9690
NOTICE: This message is for the sole use of the intended recipient(s)
and may contain confidential and privileged information. Any review,
retransmission, dissemination or other use of, or taking of any action
in reliance upon, this information by persons or entities other than
the intended recipient is prohibited. If you are not the intended
recipient, please contact the sender by reply email and destroy all
copies -- including electronic copies -- of the original message.
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [PATCH] tests, documentation, and code fixes for
Posted by Erik Hatcher <ja...@ehatchersolutions.com>.
Craeg,
I'm getting ready to apply your patches - thanks!. In the future, it would
be easier to apply if you sent a single patch file (with new files attached
separately too) based from the root of our CVS tree.
Erik
----- Original Message -----
From: "Craeg K Strong" <cs...@arielpartners.com>
To: <an...@jakarta.apache.org>
Sent: Thursday, May 16, 2002 12:20 AM
Subject: [PATCH] tests, documentation, and code fixes for <xmlcatalog>
> Hello:
>
> Based on the advice of Erik Hatcher and dIon Gillard, attached please
> find my revised set of patches for <xmlcatalog>. What is the difference?
> This patch set includes only fixes, docs, and tests. I left out the
> code that adds support for external catalog files.
>
> Since the additional feature (support for external catalogs) depends on
> these fixes and docs anyway, I am happy to adopt this more "phased"
> approach. When these fixes get landed, we can talk about what would be
> an appropriate time to introduce <catalogfiles>.
>
> Here is a manifest for the contents of the zip file:
>
> DOCS
>
> [ ant-catalog-changes/docs/manual/CoreTasks/style-html.patch ]
> Added more info about use of <xmlcatalog> for <xslt>/<style> task
>
> [ ant-catalog-changes/docs/manual/CoreTypes/xmlcatalog-html.patch ]
> Added full explanation of resolution algorithm, more examples, added link
to
> OASIS standard on which this is based, etc.
>
> [ ant-catalog-changes/docs/manual/OptionalTasks/xmlvalidate-html.patch ]
> Added more info about use of <xmlcatalog> for <xmlvalidate> task
>
> TESTS
>
> [
ant-catalog-changes/src/etc/testcases/taskdefs/optional/xmlvalidate-xml.patc
h ]
> Added testcase for double-nested <xmlcatalog> instance
>
> [
>
ant-catalog-changes/src/testcases/org/apache/tools/ant/taskdefs/optional/Xml
ValidateTest-java.patch
> ]
> Added code for testcase for double-nested <xmlcatalog> instance
>
> [
ant-catalog-changes/src/testcases/org/apache/tools/ant/types/XMLCatalogTest.
java ]
> Full suite of unit tests for <xmlcatalog>
>
> CODE
>
> [
ant-catalog-changes/src/main/org/apache/tools/ant/types/XMLCatalog-java.patc
h ]
> Refactored code, added comments, added check for circular references
>
> [
>
ant-catalog-changes/src/main/org/apache/tools/ant/taskdefs/optional/TraXLiai
son-java.patch
> ]
> Added capability to set a URIResolver as well as an EntityResolver
>
> [
>
ant-catalog-changes/src/main/org/apache/tools/ant/taskdefs/XSLTProcess-java.
patch ]
> Adds <xmlcatalog> as a URIResolver as well as an EntityResolver if present
>
>
> That's it. Please let me know if you need anything more. Thanks,
>
> --Craeg
>
----------------------------------------------------------------------------
----
> --
> To unsubscribe, e-mail: <ma...@jakarta.apache.org>
> For additional commands, e-mail: <ma...@jakarta.apache.org>
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [PATCH] tests, documentation, and code fixes for
Posted by Erik Hatcher <ja...@ehatchersolutions.com>.
Craeg,
I've applid your patch. Could you please make sure its all applied ok and
also have a look at the asserts I commented out of XMLCatalogTest that are
failing for me. It looks like a simple path issue that isn't a show
stopper.
Thanks for the doc patches and new test case especially! Always much
appreciated.
Erik
----- Original Message -----
From: "Craeg K Strong" <cs...@arielpartners.com>
To: <an...@jakarta.apache.org>
Sent: Thursday, May 16, 2002 12:20 AM
Subject: [PATCH] tests, documentation, and code fixes for <xmlcatalog>
> Hello:
>
> Based on the advice of Erik Hatcher and dIon Gillard, attached please
> find my revised set of patches for <xmlcatalog>. What is the difference?
> This patch set includes only fixes, docs, and tests. I left out the
> code that adds support for external catalog files.
>
> Since the additional feature (support for external catalogs) depends on
> these fixes and docs anyway, I am happy to adopt this more "phased"
> approach. When these fixes get landed, we can talk about what would be
> an appropriate time to introduce <catalogfiles>.
>
> Here is a manifest for the contents of the zip file:
>
> DOCS
>
> [ ant-catalog-changes/docs/manual/CoreTasks/style-html.patch ]
> Added more info about use of <xmlcatalog> for <xslt>/<style> task
>
> [ ant-catalog-changes/docs/manual/CoreTypes/xmlcatalog-html.patch ]
> Added full explanation of resolution algorithm, more examples, added link
to
> OASIS standard on which this is based, etc.
>
> [ ant-catalog-changes/docs/manual/OptionalTasks/xmlvalidate-html.patch ]
> Added more info about use of <xmlcatalog> for <xmlvalidate> task
>
> TESTS
>
> [
ant-catalog-changes/src/etc/testcases/taskdefs/optional/xmlvalidate-xml.patc
h ]
> Added testcase for double-nested <xmlcatalog> instance
>
> [
>
ant-catalog-changes/src/testcases/org/apache/tools/ant/taskdefs/optional/Xml
ValidateTest-java.patch
> ]
> Added code for testcase for double-nested <xmlcatalog> instance
>
> [
ant-catalog-changes/src/testcases/org/apache/tools/ant/types/XMLCatalogTest.
java ]
> Full suite of unit tests for <xmlcatalog>
>
> CODE
>
> [
ant-catalog-changes/src/main/org/apache/tools/ant/types/XMLCatalog-java.patc
h ]
> Refactored code, added comments, added check for circular references
>
> [
>
ant-catalog-changes/src/main/org/apache/tools/ant/taskdefs/optional/TraXLiai
son-java.patch
> ]
> Added capability to set a URIResolver as well as an EntityResolver
>
> [
>
ant-catalog-changes/src/main/org/apache/tools/ant/taskdefs/XSLTProcess-java.
patch ]
> Adds <xmlcatalog> as a URIResolver as well as an EntityResolver if present
>
>
> That's it. Please let me know if you need anything more. Thanks,
>
> --Craeg
>
----------------------------------------------------------------------------
----
> --
> To unsubscribe, e-mail: <ma...@jakarta.apache.org>
> For additional commands, e-mail: <ma...@jakarta.apache.org>
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>