You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/11/30 20:23:56 UTC

[GitHub] [hudi] alexeykudinkin opened a new pull request #4169: [HUDI-2898] Reverting "Change the default value of 'PAYLOAD_CLASS_NAME' to 'DefaultHoodieRecordPayload' (#4115)"

alexeykudinkin opened a new pull request #4169:
URL: https://github.com/apache/hudi/pull/4169


   ## *Tips*
   - *Thank you very much for contributing to Apache Hudi.*
   - *Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.*
   
   ## What is the purpose of the pull request
   
   Reverting "Change the default value of 'PAYLOAD_CLASS_NAME' to 'DefaultHoodieRecordPayload' (#4115)"
   
   See [HUDI-2898](https://issues.apache.org/jira/browse/HUDI-2898) for more details.
   
   ## Brief change log
   
   Reverting "Change the default value of 'PAYLOAD_CLASS_NAME' to 'DefaultHoodieRecordPayload' (#4115)"
   
   ## Verify this pull request
   
   Manual testing 
   
   ## Committer checklist
   
    - [ ] Has a corresponding JIRA in PR title & commit
    
    - [ ] Commit message is descriptive of the change
    
    - [ ] CI is green
   
    - [ ] Necessary doc changes done or have another open PR
          
    - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] vinothchandar commented on pull request #4169: [HUDI-2898] Reverting "Change the default value of 'PAYLOAD_CLASS_NAME' to 'DefaultHoodieRecordPayload' (#4115)"

Posted by GitBox <gi...@apache.org>.
vinothchandar commented on pull request #4169:
URL: https://github.com/apache/hudi/pull/4169#issuecomment-982998294


   Nvm. Checked out the jira. Can we fix this forward given we have been wanting to flip the default for sometime? Or pull back given we plan to think about a new cross engine non-avro abstraction?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] vinothchandar commented on pull request #4169: [HUDI-2898] Reverting "Change the default value of 'PAYLOAD_CLASS_NAME' to 'DefaultHoodieRecordPayload' (#4115)"

Posted by GitBox <gi...@apache.org>.
vinothchandar commented on pull request #4169:
URL: https://github.com/apache/hudi/pull/4169#issuecomment-982997104


   Can you please add more context on why we are reverting this? 
   
   cc @nsivabalan the original author and @danny0405 the RM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #4169: [HUDI-2898] Reverting "Change the default value of 'PAYLOAD_CLASS_NAME' to 'DefaultHoodieRecordPayload' (#4115)"

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4169:
URL: https://github.com/apache/hudi/pull/4169#issuecomment-982991785


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "64b7d9518efa067e436ed21ee40d65761f0d9dc1",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "64b7d9518efa067e436ed21ee40d65761f0d9dc1",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 64b7d9518efa067e436ed21ee40d65761f0d9dc1 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #4169: [HUDI-2898] Reverting "Change the default value of 'PAYLOAD_CLASS_NAME' to 'DefaultHoodieRecordPayload' (#4115)"

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4169:
URL: https://github.com/apache/hudi/pull/4169#issuecomment-983035517


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "64b7d9518efa067e436ed21ee40d65761f0d9dc1",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3900",
       "triggerID" : "64b7d9518efa067e436ed21ee40d65761f0d9dc1",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 64b7d9518efa067e436ed21ee40d65761f0d9dc1 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3900) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot removed a comment on pull request #4169: [HUDI-2898] Reverting "Change the default value of 'PAYLOAD_CLASS_NAME' to 'DefaultHoodieRecordPayload' (#4115)"

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4169:
URL: https://github.com/apache/hudi/pull/4169#issuecomment-982991785


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "64b7d9518efa067e436ed21ee40d65761f0d9dc1",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "64b7d9518efa067e436ed21ee40d65761f0d9dc1",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 64b7d9518efa067e436ed21ee40d65761f0d9dc1 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] alexeykudinkin commented on pull request #4169: [HUDI-2898] Reverting "Change the default value of 'PAYLOAD_CLASS_NAME' to 'DefaultHoodieRecordPayload' (#4115)"

Posted by GitBox <gi...@apache.org>.
alexeykudinkin commented on pull request #4169:
URL: https://github.com/apache/hudi/pull/4169#issuecomment-983009074


   I'm fine either way, but just for the sake of speed and stability, i'd much rather tackle this as part of 0.11 release


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] alexeykudinkin commented on pull request #4169: [HUDI-2898] Reverting "Change the default value of 'PAYLOAD_CLASS_NAME' to 'DefaultHoodieRecordPayload' (#4115)"

Posted by GitBox <gi...@apache.org>.
alexeykudinkin commented on pull request #4169:
URL: https://github.com/apache/hudi/pull/4169#issuecomment-982995340


   @leesf @dongkelun FYI


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot removed a comment on pull request #4169: [HUDI-2898] Reverting "Change the default value of 'PAYLOAD_CLASS_NAME' to 'DefaultHoodieRecordPayload' (#4115)"

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4169:
URL: https://github.com/apache/hudi/pull/4169#issuecomment-982993762


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "64b7d9518efa067e436ed21ee40d65761f0d9dc1",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3900",
       "triggerID" : "64b7d9518efa067e436ed21ee40d65761f0d9dc1",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 64b7d9518efa067e436ed21ee40d65761f0d9dc1 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3900) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] yihua merged pull request #4169: [HUDI-2898] Reverting "Change the default value of 'PAYLOAD_CLASS_NAME' to 'DefaultHoodieRecordPayload' (#4115)"

Posted by GitBox <gi...@apache.org>.
yihua merged pull request #4169:
URL: https://github.com/apache/hudi/pull/4169


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] nsivabalan commented on pull request #4169: [HUDI-2898] Reverting "Change the default value of 'PAYLOAD_CLASS_NAME' to 'DefaultHoodieRecordPayload' (#4115)"

Posted by GitBox <gi...@apache.org>.
nsivabalan commented on pull request #4169:
URL: https://github.com/apache/hudi/pull/4169#issuecomment-983187027


   Here is our reasoning. Our existing tests did not catch this bug. And so, feeling skeptical there could be few other issues. Would prefer to revert it.  


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #4169: [HUDI-2898] Reverting "Change the default value of 'PAYLOAD_CLASS_NAME' to 'DefaultHoodieRecordPayload' (#4115)"

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4169:
URL: https://github.com/apache/hudi/pull/4169#issuecomment-982993762


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "64b7d9518efa067e436ed21ee40d65761f0d9dc1",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3900",
       "triggerID" : "64b7d9518efa067e436ed21ee40d65761f0d9dc1",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 64b7d9518efa067e436ed21ee40d65761f0d9dc1 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3900) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org