You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by Mehant Baid <ba...@gmail.com> on 2015/02/04 19:30:21 UTC
Review Request 30629: DRILL-2142: Refactor AbstractContainerVector
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30629/
-----------------------------------------------------------
Review request for drill and Jacques Nadeau.
Bugs: DRILL-2142
https://issues.apache.org/jira/browse/DRILL-2142
Repository: drill-git
Description
-------
This patch moves the logic specific to maps in a new class AbstractMapVector from AbstractContainerVector.
Diffs
-----
exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/AbstractContainerVector.java fdfddfb
exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/AbstractMapVector.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/MapVector.java 1c3cee1
exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/RepeatedMapVector.java 7e1b353
Diff: https://reviews.apache.org/r/30629/diff/
Testing
-------
Thanks,
Mehant Baid
Re: Review Request 30629: DRILL-2142: Refactor AbstractContainerVector
Posted by Hanifi Gunes <hg...@maprtech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30629/#review71110
-----------------------------------------------------------
Ship it!
+1 (non-binding) container vector and its sub-classes will require further refactoring for instance not all sub-classes support child look-up by name. That is, however, beyond the scope this issue. We should take care of this on top of DRILL-2150. overall looks good to me.
- Hanifi Gunes
On Feb. 4, 2015, 6:30 p.m., Mehant Baid wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30629/
> -----------------------------------------------------------
>
> (Updated Feb. 4, 2015, 6:30 p.m.)
>
>
> Review request for drill and Jacques Nadeau.
>
>
> Bugs: DRILL-2142
> https://issues.apache.org/jira/browse/DRILL-2142
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> This patch moves the logic specific to maps in a new class AbstractMapVector from AbstractContainerVector.
>
>
> Diffs
> -----
>
> exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/AbstractContainerVector.java fdfddfb
> exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/AbstractMapVector.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/MapVector.java 1c3cee1
> exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/RepeatedMapVector.java 7e1b353
>
> Diff: https://reviews.apache.org/r/30629/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mehant Baid
>
>