[jira] [Commented] (PROTON-2377) [cpp] tag_counter is not used in a thread safe way in sender.cpp

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PROTON-2377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17327255#comment-17327255 ] 

ASF GitHub Bot commented on PROTON-2377:
----------------------------------------

DreamPearl opened a new pull request #310:
URL: https://github.com/apache/qpid-proton/pull/310


   Issue: https://issues.apache.org/jira/browse/PROTON-2377 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> [cpp] tag_counter is not used in a thread safe way in sender.cpp
> ----------------------------------------------------------------
>
>                 Key: PROTON-2377
>                 URL: https://issues.apache.org/jira/browse/PROTON-2377
>             Project: Qpid Proton
>          Issue Type: Bug
>          Components: cpp-binding
>            Reporter: Rakhi Kumari
>            Priority: Major
>
> uint64_t tag_counter = 0 is a global variable, so it might end up giving duplicate ids to different threads.
> We need to ensure that a single sender will not send a message with a duplicate tag. Thread safety is required to guarantee unique tags. 
> Link to the discussion regarding this issue :
> https://github.com/apache/qpid-proton/pull/309#discussion_r615219442



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org