[GitHub] [logging-log4j2] ppkarwasz commented on a change in pull request #709: Adds default property values to TTCCLayout (Log4j 1.x bridge)

[GitBox <gi...@apache.org>]

ppkarwasz commented on a change in pull request #709:
URL: https://github.com/apache/logging-log4j2/pull/709#discussion_r787887554



##########
File path: log4j-1.2-api/src/main/java/org/apache/log4j/builders/layout/TTCCLayoutBuilder.java
##########
@@ -91,10 +91,10 @@ public Layout parseLayout(Element layoutElement, XmlConfiguration config) {
 
     @Override
     public Layout parseLayout(PropertiesConfiguration config) {
-        boolean threadPrinting = getBooleanProperty(THREAD_PRINTING_PARAM);
-        boolean categoryPrefixing = getBooleanProperty(CATEGORY_PREFIXING_PARAM);
-        boolean contextPrinting = getBooleanProperty(CONTEXT_PRINTING_PARAM);
-        String dateFormat = getProperty(DATE_FORMAT_PARAM);
+        boolean threadPrinting = getBooleanProperty(THREAD_PRINTING_PARAM, true);

Review comment:
       I added a test, which was failing before.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org