You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/02/01 08:33:17 UTC
[GitHub] [apisix-dashboard] Jaycean opened a new pull request #1409: fix(be): push pr ci failed
Jaycean opened a new pull request #1409:
URL: https://github.com/apache/apisix-dashboard/pull/1409
Please answer these questions before submitting a pull request
- Why submit this pull request?
- [x] Bugfix
- [ ] New feature provided
- [ ] Improve performance
- [ ] Backport patches
- Related issues
___
### Bugfix
- Description
[Failed installing dependency,Could not find header file for OPENSSL](https://github.com/apache/apisix-dashboard/runs/1804604649)
- How to fix?
Dockerfile-apisix adds the specified OpenSSL library address.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] Fuchange commented on pull request #1409: fix(be): push pr ci failed
Posted by GitBox <gi...@apache.org>.
Fuchange commented on pull request #1409:
URL: https://github.com/apache/apisix-dashboard/pull/1409#issuecomment-770699481
> Do we have a way to reuse apisix docker file in `apisix-docker` repo instead of a separate file in dashboard?
Yes, we can use
`https://github.com/apache/apisix-docker/raw/master/all-in-one/apisix/Dockerfile`
`https://github.com/apache/apisix-docker/raw/master/all-in-one/apisix-dashboard/Dockerfile`
to replace the existing local dockerfile
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran edited a comment on pull request #1409: fix(be): push pr ci failed
Posted by GitBox <gi...@apache.org>.
liuxiran edited a comment on pull request #1409:
URL: https://github.com/apache/apisix-dashboard/pull/1409#issuecomment-770709643
an unstable fe test case , re-run, I opened an issue https://github.com/apache/apisix-dashboard/issues/1410 to trace it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on pull request #1409: fix(be): push pr ci failed
Posted by GitBox <gi...@apache.org>.
liuxiran commented on pull request #1409:
URL: https://github.com/apache/apisix-dashboard/pull/1409#issuecomment-770709643
an unstable fe test case , re-run, I opened an issue https://github.com/apache/apisix-dashboard/pull/1409/checks?check_run_id=1805078346 to trace it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] imjoey merged pull request #1409: fix(be): push pr ci failed
Posted by GitBox <gi...@apache.org>.
imjoey merged pull request #1409:
URL: https://github.com/apache/apisix-dashboard/pull/1409
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io commented on pull request #1409: fix(be): push pr ci failed
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1409:
URL: https://github.com/apache/apisix-dashboard/pull/1409#issuecomment-770682092
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1409?src=pr&el=h1) Report
> Merging [#1409](https://codecov.io/gh/apache/apisix-dashboard/pull/1409?src=pr&el=desc) (dc57571) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/bff19b5336485e4ec62666cf518ec22bfbb6370d?el=desc) (bff19b5) will **increase** coverage by `0.46%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1409?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1409 +/- ##
==========================================
+ Coverage 44.72% 45.19% +0.46%
==========================================
Files 35 35
Lines 2522 2516 -6
==========================================
+ Hits 1128 1137 +9
+ Misses 1233 1214 -19
- Partials 161 165 +4
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1409?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [api/internal/handler/upstream/upstream.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1409/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvdXBzdHJlYW0vdXBzdHJlYW0uZ28=) | `28.81% <0.00%> (+8.65%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1409?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1409?src=pr&el=footer). Last update [bff19b5...dc57571](https://codecov.io/gh/apache/apisix-dashboard/pull/1409?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on pull request #1409: fix(be): push pr ci failed
Posted by GitBox <gi...@apache.org>.
liuxiran commented on pull request #1409:
URL: https://github.com/apache/apisix-dashboard/pull/1409#issuecomment-770706659
> > Do we have a way to reuse apisix docker file in `apisix-docker` repo instead of a separate file in dashboard?
>
> Yes, we can use
> `https://github.com/apache/apisix-docker/raw/master/all-in-one/apisix/Dockerfile`
> `https://github.com/apache/apisix-docker/raw/master/all-in-one/apisix-dashboard/Dockerfile`
>
> to replace the existing local dockerfile
Sound cool @Fuchange , maybe we can open a new issue to discuess this feature, thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] Jaycean commented on pull request #1409: fix(be): push pr ci failed
Posted by GitBox <gi...@apache.org>.
Jaycean commented on pull request #1409:
URL: https://github.com/apache/apisix-dashboard/pull/1409#issuecomment-770704917
@liuxiran @Fuchange IMO, it is better to use a unified file, which is convenient for maintenance.Today's problem will appear if you maintain the Dockerfile of APISIX in the dashboard. The modification of APISIX does not synchronize with the update, resulting in errors.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on pull request #1409: fix(be): push pr ci failed
Posted by GitBox <gi...@apache.org>.
liuxiran commented on pull request #1409:
URL: https://github.com/apache/apisix-dashboard/pull/1409#issuecomment-770690009
Do we have a way to reuse apisix docker file in `apisix-docker` repo instead of a separate file in dashboard?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] Jaycean commented on pull request #1409: fix(be): push pr ci failed
Posted by GitBox <gi...@apache.org>.
Jaycean commented on pull request #1409:
URL: https://github.com/apache/apisix-dashboard/pull/1409#issuecomment-770706104
ping @starsz @nic-chen @imjoey @tokers for review. Thks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org