[GitHub] StefanRRichter commented on issue #6739: [FLINK-10289] [JobManager] Classify Exceptions to different category for apply different failover strategy

[GitBox <gi...@apache.org>]

StefanRRichter commented on issue #6739: [FLINK-10289] [JobManager] Classify Exceptions to different category for apply different failover strategy
URL: https://github.com/apache/flink/pull/6739#issuecomment-427087088
 
 
   @isunjin I also like the general idea, but not so much the current implementation. One disadvantage I see with the annotation is that they are not propagated in inheritance hierarchies and you always need to remember adding them in such a case. I also wonder where and how this classifier will be invoked later. Maybe an alternative approach could be to have a fixed set of `TaskException`s for the cases, and before leaving the TM, all exceptions are wrapped as cause into their matching `TaskException`  to classify them for the JM's recovery approach. However, the "best" approach might also depend on the intended use, which is not clear for me from the PR and that is why I am asking.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services