You are viewing a plain text version of this content. The canonical link for it is here.

Posted to derby-dev@db.apache.org by "Kristian Waagan (JIRA)" <ji...@apache.org> on 2008/02/18 14:34:34 UTC

[jira] Commented: (DERBY-3425) J2EEDataSourceTest throws away stack trace for many errors

    [ https://issues.apache.org/jira/browse/DERBY-3425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12569896#action_12569896 ] 

Kristian Waagan commented on DERBY-3425:
----------------------------------------

The changes look good to me.
They preserve the stack traces if an error occurs, and they also make the code cleaner.
I ran the test without failures with the patch applied.

+1 to commit

> J2EEDataSourceTest throws away stack trace for many errors
> ----------------------------------------------------------
>
>                 Key: DERBY-3425
>                 URL: https://issues.apache.org/jira/browse/DERBY-3425
>             Project: Derby
>          Issue Type: Bug
>          Components: Test
>    Affects Versions: 10.4.0.0
>            Reporter: Knut Anders Hatlen
>            Assignee: Knut Anders Hatlen
>            Priority: Minor
>         Attachments: stack.diff
>
>
> Many of the test cases in J2EEDataSourceTest call fail() from within a catch block. Instead, they should just let the exception be thrown and let JUnit handle it. This way the stack trace will be preserved.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.