You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@brpc.apache.org by GitBox <gi...@apache.org> on 2022/07/25 23:42:11 UTC

[GitHub] [incubator-brpc] wasphin commented on a diff in pull request #1857: Fix cmake Build in MacOS

wasphin commented on code in PR #1857:
URL: https://github.com/apache/incubator-brpc/pull/1857#discussion_r929394879


##########
cmake/brpc.pc.in:
##########
@@ -23,4 +23,4 @@ Description: An industrial-grade RPC framework used throughout Baidu, with 1,000
 Version: @BRPC_VERSION@
 Cflags: -I${includedir}
 Libs: -L${libdir}/ -lbrpc
-Libs.private: @BRPC_PRIVATE_LIBS@
+Libs.private: @DYNAMIC_LIB@

Review Comment:
   pkg-config 依赖静态库时会不会有问题？



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org