[GitHub] [geode] balesh2 opened pull request #3214: GEODE-6425: fix rollover of get stats

["balesh2 (GitHub)" <gi...@apache.org>]

Changes gets, misses, getFailures, and getTimeouts stats from int to
long so that they don't rollover as quickly.

Signed-off-by: Jacob Barrett <jb...@pivotal.io>

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/3214 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] moleske commented on pull request #3214: GEODE-6425: fix rollover of get stats

["moleske (GitHub)" <gi...@apache.org>]

Thanks you for adding this test!

[ Full content available at: https://github.com/apache/geode/pull/3214 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] moleske commented on pull request #3214: GEODE-6425: fix rollover of get stats

["moleske (GitHub)" <gi...@apache.org>]

If we're updating this file it might be nice to update the name `test000put` but I wouldn't block this PR on something minor

[ Full content available at: https://github.com/apache/geode/pull/3214 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] balesh2 commented on pull request #3214: GEODE-6425: fix rollover of get stats

["balesh2 (GitHub)" <gi...@apache.org>]

👍 you're welcome

[ Full content available at: https://github.com/apache/geode/pull/3214 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] balesh2 commented on pull request #3214: GEODE-6425: fix rollover of get stats

["balesh2 (GitHub)" <gi...@apache.org>]

Unfortunately I don't know that we can really do better with the naming without refactoring (or more likely rewriting) this whole class. The methods are numbered because they have to be run in order or they break, and this test does waaaayyy too much in one method to give it a proper name. I would like to rename it though

[ Full content available at: https://github.com/apache/geode/pull/3214 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] pivotal-jbarrett closed pull request #3214: GEODE-6425: fix rollover of get stats

["pivotal-jbarrett (GitHub)" <gi...@apache.org>]

[ pull request closed by pivotal-jbarrett ]

[ Full content available at: https://github.com/apache/geode/pull/3214 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] moleske commented on pull request #3214: GEODE-6425: fix rollover of get stats

["moleske (GitHub)" <gi...@apache.org>]

I'm really liking how this was tested!  I don't think it would have ever dawned on me to check both int and long.

[ Full content available at: https://github.com/apache/geode/pull/3214 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org