[GitHub] [nifi] natural opened a new pull request #4096: NIFI-7153 Adds ContentLengthFilter and DosFilter to web contexts.

[GitBox <gi...@apache.org>]

natural opened a new pull request #4096: NIFI-7153 Adds ContentLengthFilter and DosFilter to web contexts.
URL: https://github.com/apache/nifi/pull/4096
 
 
   #### NIFI-7153 Limit Length of Component Properties (by limiting HTTP request sizes)
   
   _The code in this change-set adds a new ContentLengthFilter and introduces the DosFilter from the jetty project_
   
   These changes effect every byte that passes thru the HTTP API and HTTP UI so this code needs thorough review and wide testing.
   
   The `ContentLengthFilter` is new and currently activated via code in `JettyServer.java`.  I think the filter should be activated via the various web.xml files but my initial attempts at integrating that way were unsuccessful.  The current activation uses the default of 10MB for the limit on PUT/POST requests to all API and UI contexts.
   
   Before completing the new filter, I attempted to use the `maxFormContentSize` setting to produce the limiting behavior.  Unfortunately, that value is only referenced during `application/x-form-encoded`-type requests, not our typical PUT with `application/json`.  This change-set includes a unit test that demonstrates this distinction.
   
   There is a small change to the UI code to account for the `413` responses returned by the server.
   
   The `DosFilter` is from the jetty project and activated via the `webdefaults.xml` file.  I've set reasonable defaults that allow me to use the application as a user and still trigger the DoS filter behavior with a benchmark (such as `wrk`).
   
   Finally, there is a new behavior introduced by the `ContentLengthFilter` class that will effect older, HTTP 1.0 and non-conforming HTTP user agents.  When a PUT or POST HTTP request is made without sending a `Content-Length` header, the server will now respond with `411 Length Required`.
   
   Remaining steps:
    - finalize activation point for both filters (xml vs code)
    - finalize defaults for both filters
    - apply options to specific contexts/endpoints as necessary
   
   
   
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [x] Is there a JIRA ticket associated with this PR? Is it referenced 
        in the commit message?
   
   - [x] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
   
   - [x] Has your PR been rebased against the latest commit within the target branch (typically `master`)?
   
   - [x] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._
   
   ### For code changes:
   - [x] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder?
   - [x] Have you written or updated unit tests to verify your changes?
   - [ ] Have you verified that the full build is successful on both JDK 8 and JDK 11?
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
   - [ ] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`?
   - [ ] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`?
   - [ ] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties?
   
   ### For documentation related changes:
   - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
   
   ### Note:
   Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [nifi] natural closed pull request #4096: NIFI-7153 Adds ContentLengthFilter and DosFilter to web contexts.

[GitBox <gi...@apache.org>]

natural closed pull request #4096: NIFI-7153 Adds ContentLengthFilter and DosFilter to web contexts.
URL: https://github.com/apache/nifi/pull/4096
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services