You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "IgorZolin (via GitHub)" <gi...@apache.org> on 2026/09/18 17:42:33 UTC
[PR] add arj compression [commons-compress]
IgorZolin opened a new pull request, #815:
URL: https://github.com/apache/commons-compress/pull/815
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
https://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for your contribution to [Apache Commons](https://commons.apache.org/)! Your help is appreciated!
Before you push a pull request, review this list:
- [*] Read the [contribution guidelines](CONTRIBUTING.md) for this project.
- [*] Read the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) if you use Artificial Intelligence (AI).
- [*] I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute? (opencode + Big Pickle)
- [*] Run a successful build using the default [Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command line by itself.
- [*] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice.
- [*] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [*] Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process.
Add arj archives decompression.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] add arj compression [commons-compress]
Posted by "IgorZolin (via GitHub)" <gi...@apache.org>.
IgorZolin commented on code in PR #815:
URL: https://github.com/apache/commons-compress/pull/815#discussion_r4081443322
##########
src/main/java/org/apache/commons/compress/archivers/arj/CircularBuffer.java:
##########
@@ -0,0 +1,109 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.commons.compress.archivers.arj;
+
+/**
+ * Circular byte buffer. Copied from org.apache.commons.compress.archivers.lha.CircularBuffer and modified for ARJ.
Review Comment:
> You didn't follow the template instructions, so the build is broken...
sorry, i've fix lint promlems, can we run build?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] add arj compression [commons-compress]
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on code in PR #815:
URL: https://github.com/apache/commons-compress/pull/815#discussion_r4053475049
##########
src/main/java/org/apache/commons/compress/archivers/arj/CircularBuffer.java:
##########
@@ -0,0 +1,109 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.commons.compress.archivers.arj;
+
+/**
+ * Circular byte buffer. Copied from org.apache.commons.compress.archivers.lha.CircularBuffer and modified for ARJ.
Review Comment:
You didn't follow the template instructions, so the build is broken...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] add arj compression [commons-compress]
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on code in PR #815:
URL: https://github.com/apache/commons-compress/pull/815#discussion_r4053473612
##########
src/main/java/org/apache/commons/compress/archivers/arj/CircularBuffer.java:
##########
@@ -0,0 +1,109 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.commons.compress.archivers.arj;
+
+/**
+ * Circular byte buffer. Copied from org.apache.commons.compress.archivers.lha.CircularBuffer and modified for ARJ.
Review Comment:
That's what unit tests are for ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] add arj compression [commons-compress]
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on code in PR #815:
URL: https://github.com/apache/commons-compress/pull/815#discussion_r4049262443
##########
src/main/java/org/apache/commons/compress/archivers/arj/CircularBuffer.java:
##########
@@ -0,0 +1,109 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.commons.compress.archivers.arj;
+
+/**
+ * Circular byte buffer. Copied from org.apache.commons.compress.archivers.lha.CircularBuffer and modified for ARJ.
Review Comment:
@IgorZolin
Modified how? Can we reduce the copy pasta and have a shared implementation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] add arj compression [commons-compress]
Posted by "IgorZolin (via GitHub)" <gi...@apache.org>.
IgorZolin commented on PR #815:
URL: https://github.com/apache/commons-compress/pull/815#issuecomment-5755507286
ok, i can pause my pr and update it after yours pr would be merged?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] add arj compression [commons-compress]
Posted by "IgorZolin (via GitHub)" <gi...@apache.org>.
IgorZolin commented on code in PR #815:
URL: https://github.com/apache/commons-compress/pull/815#discussion_r4053396965
##########
src/main/java/org/apache/commons/compress/archivers/arj/CircularBuffer.java:
##########
@@ -0,0 +1,109 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.commons.compress.archivers.arj;
+
+/**
+ * Circular byte buffer. Copied from org.apache.commons.compress.archivers.lha.CircularBuffer and modified for ARJ.
Review Comment:
Sorry, it was not really modified, just don't want to change someones code. I could make lha.CircularBuffer public and reuse it (there would be some risk that changes in lha could broke arj).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] add arj compression [commons-compress]
Posted by "fkjellberg (via GitHub)" <gi...@apache.org>.
fkjellberg commented on PR #815:
URL: https://github.com/apache/commons-compress/pull/815#issuecomment-5750189396
Hi @IgorZolin
Thanks for improving ARJ decompression support. Please take a look at my [PR 812](https://github.com/apache/commons-compress/pull/812) which replaces the `BinaryTree` implementation with the new `HuffmanDecoder` for LHA. The same refactor should work here as well. It will improve code reuse and significantly reduce memory usage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org