svn commit: r1453121 - in /commons/proper/fileupload/trunk/src/main/java/org/apache/commons/fileupload: FileUploadBase.java disk/DiskFileItem.java util/FileItemHeadersImpl.java

[se...@apache.org]

Author: sebb
Date: Wed Mar  6 01:44:03 2013
New Revision: 1453121

URL: http://svn.apache.org/r1453121
Log:
Unnecessary casts, now that collections have been given types

Modified:
    commons/proper/fileupload/trunk/src/main/java/org/apache/commons/fileupload/FileUploadBase.java
    commons/proper/fileupload/trunk/src/main/java/org/apache/commons/fileupload/disk/DiskFileItem.java
    commons/proper/fileupload/trunk/src/main/java/org/apache/commons/fileupload/util/FileItemHeadersImpl.java

Modified: commons/proper/fileupload/trunk/src/main/java/org/apache/commons/fileupload/FileUploadBase.java
URL: http://svn.apache.org/viewvc/commons/proper/fileupload/trunk/src/main/java/org/apache/commons/fileupload/FileUploadBase.java?rev=1453121&r1=1453120&r2=1453121&view=diff
==============================================================================
--- commons/proper/fileupload/trunk/src/main/java/org/apache/commons/fileupload/FileUploadBase.java (original)
+++ commons/proper/fileupload/trunk/src/main/java/org/apache/commons/fileupload/FileUploadBase.java Wed Mar  6 01:44:03 2013
@@ -416,7 +416,7 @@ public abstract class FileUploadBase {
         parser.setLowerCaseNames(true);
         // Parameter parser can handle null input
         Map<String, String> params = parser.parse(contentType, new char[] {';', ','});
-        String boundaryStr = (String) params.get("boundary");
+        String boundaryStr = params.get("boundary");
 
         if (boundaryStr == null) {
             return null;
@@ -472,7 +472,7 @@ public abstract class FileUploadBase {
                 // Parameter parser can handle null input
                 Map<String, String> params = parser.parse(pContentDisposition, ';');
                 if (params.containsKey("filename")) {
-                    fileName = (String) params.get("filename");
+                    fileName = params.get("filename");
                     if (fileName != null) {
                         fileName = fileName.trim();
                     } else {
@@ -514,7 +514,7 @@ public abstract class FileUploadBase {
             parser.setLowerCaseNames(true);
             // Parameter parser can handle null input
             Map<String, String> params = parser.parse(pContentDisposition, ';');
-            fieldName = (String) params.get("name");
+            fieldName = params.get("name");
             if (fieldName != null) {
                 fieldName = fieldName.trim();
             }
@@ -634,7 +634,7 @@ public abstract class FileUploadBase {
         for (Iterator<String> iter = headers.getHeaderNames();  iter.hasNext();) {
             String headerName = iter.next();
             Iterator<String> iter2 = headers.getHeaders(headerName);
-            String headerValue = (String) iter2.next();
+            String headerValue = iter2.next();
             while (iter2.hasNext()) {
                 headerValue += "," + iter2.next();
             }
@@ -697,7 +697,7 @@ public abstract class FileUploadBase {
     @Deprecated
     protected final String getHeader(Map<String, String> headers,
             String name) {
-        return (String) headers.get(name.toLowerCase());
+        return headers.get(name.toLowerCase());
     }
 
     /**

Modified: commons/proper/fileupload/trunk/src/main/java/org/apache/commons/fileupload/disk/DiskFileItem.java
URL: http://svn.apache.org/viewvc/commons/proper/fileupload/trunk/src/main/java/org/apache/commons/fileupload/disk/DiskFileItem.java?rev=1453121&r1=1453120&r2=1453121&view=diff
==============================================================================
--- commons/proper/fileupload/trunk/src/main/java/org/apache/commons/fileupload/disk/DiskFileItem.java (original)
+++ commons/proper/fileupload/trunk/src/main/java/org/apache/commons/fileupload/disk/DiskFileItem.java Wed Mar  6 01:44:03 2013
@@ -266,7 +266,7 @@ public class DiskFileItem
         parser.setLowerCaseNames(true);
         // Parameter parser can handle null input
         Map<String, String> params = parser.parse(getContentType(), ';');
-        return (String) params.get("charset");
+        return params.get("charset");
     }
 
 

Modified: commons/proper/fileupload/trunk/src/main/java/org/apache/commons/fileupload/util/FileItemHeadersImpl.java
URL: http://svn.apache.org/viewvc/commons/proper/fileupload/trunk/src/main/java/org/apache/commons/fileupload/util/FileItemHeadersImpl.java?rev=1453121&r1=1453120&r2=1453121&view=diff
==============================================================================
--- commons/proper/fileupload/trunk/src/main/java/org/apache/commons/fileupload/util/FileItemHeadersImpl.java (original)
+++ commons/proper/fileupload/trunk/src/main/java/org/apache/commons/fileupload/util/FileItemHeadersImpl.java Wed Mar  6 01:44:03 2013
@@ -47,7 +47,7 @@ public class FileItemHeadersImpl impleme
         if (null == headerValueList) {
             return null;
         }
-        return (String) headerValueList.get(0);
+        return headerValueList.get(0);
     }
 
     public Iterator<String> getHeaderNames() {