You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2020/03/19 19:30:57 UTC
[GitHub] [incubator-gobblin] codecov-io edited a comment on issue #2932:
added some logs, fix checkstyle, removed some redundant code
codecov-io edited a comment on issue #2932: added some logs, fix checkstyle, removed some redundant code
URL: https://github.com/apache/incubator-gobblin/pull/2932#issuecomment-601366246
# [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2932?src=pr&el=h1) Report
> Merging [#2932](https://codecov.io/gh/apache/incubator-gobblin/pull/2932?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/65e2a64d2e40f46203837f4785c2426eae29a12e&el=desc) will **decrease** coverage by `0.92%`.
> The diff coverage is `66.66%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/2932?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2932 +/- ##
============================================
- Coverage 45.55% 44.63% -0.93%
+ Complexity 9143 8978 -165
============================================
Files 1936 1936
Lines 73208 73208
Branches 8080 8080
============================================
- Hits 33349 32673 -676
- Misses 36766 37486 +720
+ Partials 3093 3049 -44
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2932?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...obblin/service/FlowConfigResourceLocalHandler.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2932/diff?src=pr&el=tree#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi1mbG93LWNvbmZpZy1zZXJ2aWNlL2dvYmJsaW4tZmxvdy1jb25maWctc2VydmljZS1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vc2VydmljZS9GbG93Q29uZmlnUmVzb3VyY2VMb2NhbEhhbmRsZXIuamF2YQ==) | `13.67% <0.00%> (ø)` | `2.00 <0.00> (ø)` | |
| [...blin/service/FlowConfigV2ResourceLocalHandler.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2932/diff?src=pr&el=tree#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi1mbG93LWNvbmZpZy1zZXJ2aWNlL2dvYmJsaW4tZmxvdy1jb25maWctc2VydmljZS1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vc2VydmljZS9GbG93Q29uZmlnVjJSZXNvdXJjZUxvY2FsSGFuZGxlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [.../modules/scheduler/GobblinServiceJobScheduler.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2932/diff?src=pr&el=tree#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9zY2hlZHVsZXIvR29iYmxpblNlcnZpY2VKb2JTY2hlZHVsZXIuamF2YQ==) | `52.04% <ø> (+1.18%)` | `15.00 <0.00> (ø)` | |
| [...ache/gobblin/runtime/spec\_catalog/FlowCatalog.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2932/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvc3BlY19jYXRhbG9nL0Zsb3dDYXRhbG9nLmphdmE=) | `47.32% <50.00%> (-0.37%)` | `16.00 <0.00> (ø)` | |
| [.../java/org/apache/gobblin/runtime/api/FlowSpec.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2932/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvYXBpL0Zsb3dTcGVjLmphdmE=) | `52.59% <100.00%> (+0.35%)` | `13.00 <1.00> (+1.00)` | |
| [...dules/flowgraph/pathfinder/AbstractPathFinder.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2932/diff?src=pr&el=tree#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9mbG93Z3JhcGgvcGF0aGZpbmRlci9BYnN0cmFjdFBhdGhGaW5kZXIuamF2YQ==) | `87.90% <100.00%> (+0.19%)` | `30.00 <0.00> (ø)` | |
| [...ce/modules/flowgraph/pathfinder/BFSPathFinder.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2932/diff?src=pr&el=tree#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9mbG93Z3JhcGgvcGF0aGZpbmRlci9CRlNQYXRoRmluZGVyLmphdmE=) | `80.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...gobblin/runtime/mapreduce/GobblinOutputFormat.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2932/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvbWFwcmVkdWNlL0dvYmJsaW5PdXRwdXRGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...askStateCollectorServiceHiveRegHandlerFactory.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2932/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvVGFza1N0YXRlQ29sbGVjdG9yU2VydmljZUhpdmVSZWdIYW5kbGVyRmFjdG9yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...re/filesystem/FsDatasetStateStoreEntryManager.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2932/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvbWV0YXN0b3JlL2ZpbGVzeXN0ZW0vRnNEYXRhc2V0U3RhdGVTdG9yZUVudHJ5TWFuYWdlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [46 more](https://codecov.io/gh/apache/incubator-gobblin/pull/2932/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2932?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2932?src=pr&el=footer). Last update [65e2a64...7790679](https://codecov.io/gh/apache/incubator-gobblin/pull/2932?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services