You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/07/12 20:20:36 UTC
[GitHub] [iceberg] aokolnychyi opened a new pull request #2811: Spark: Add missing deprecation annotations for old actions
aokolnychyi opened a new pull request #2811:
URL: https://github.com/apache/iceberg/pull/2811
This PR adds missing deprecation annotations for old Spark actions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] jshmchenxi commented on a change in pull request #2811: Spark: Add missing deprecation annotations for old actions
Posted by GitBox <gi...@apache.org>.
jshmchenxi commented on a change in pull request #2811:
URL: https://github.com/apache/iceberg/pull/2811#discussion_r671052271
##########
File path: spark/src/main/java/org/apache/iceberg/actions/RewriteDataFilesAction.java
##########
@@ -32,6 +32,10 @@
import org.apache.spark.broadcast.Broadcast;
import org.apache.spark.sql.SparkSession;
+/**
+ * @deprecated since 0.12.0, will be removed in 0.13.0; use {@link RewriteDataFilesAction} instead.
+ */
+@Deprecated
Review comment:
Hi, should we use `BaseRewriteDataFilesAction` instead? `RewriteDataFilesAction` is the deprecated class itself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] aokolnychyi commented on pull request #2811: Spark: Add missing deprecation annotations for old actions
Posted by GitBox <gi...@apache.org>.
aokolnychyi commented on pull request #2811:
URL: https://github.com/apache/iceberg/pull/2811#issuecomment-878798924
Thanks, @kbendick @rdblue @flyrain @RussellSpitzer!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] aokolnychyi merged pull request #2811: Spark: Add missing deprecation annotations for old actions
Posted by GitBox <gi...@apache.org>.
aokolnychyi merged pull request #2811:
URL: https://github.com/apache/iceberg/pull/2811
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] flyrain commented on pull request #2811: Spark: Add missing deprecation annotations for old actions
Posted by GitBox <gi...@apache.org>.
flyrain commented on pull request #2811:
URL: https://github.com/apache/iceberg/pull/2811#issuecomment-878586956
+1 for the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] aokolnychyi commented on pull request #2811: Spark: Add missing deprecation annotations for old actions
Posted by GitBox <gi...@apache.org>.
aokolnychyi commented on pull request #2811:
URL: https://github.com/apache/iceberg/pull/2811#issuecomment-878568617
@kbendick @karuppayya @RussellSpitzer @rdblue @flyrain, could you review, please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] aokolnychyi commented on pull request #2811: Spark: Add missing deprecation annotations for old actions
Posted by GitBox <gi...@apache.org>.
aokolnychyi commented on pull request #2811:
URL: https://github.com/apache/iceberg/pull/2811#issuecomment-878604565
This failed as we need to get #2810 first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] jshmchenxi commented on a change in pull request #2811: Spark: Add missing deprecation annotations for old actions
Posted by GitBox <gi...@apache.org>.
jshmchenxi commented on a change in pull request #2811:
URL: https://github.com/apache/iceberg/pull/2811#discussion_r671052271
##########
File path: spark/src/main/java/org/apache/iceberg/actions/RewriteDataFilesAction.java
##########
@@ -32,6 +32,10 @@
import org.apache.spark.broadcast.Broadcast;
import org.apache.spark.sql.SparkSession;
+/**
+ * @deprecated since 0.12.0, will be removed in 0.13.0; use {@link RewriteDataFilesAction} instead.
+ */
+@Deprecated
Review comment:
Hi, should we use `BaseRewriteDataFilesSparkAction` instead? `RewriteDataFilesAction` is the deprecated class itself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org