You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Bharat Viswanadham <bh...@us.ibm.com> on 2017/04/13 20:44:34 UTC

Re: Review Request 56677: Kafka still showing deprecated property log.cleanup.interval.mins in Config Section of Kafka on Ambari

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56677/
-----------------------------------------------------------

(Updated April 13, 2017, 8:44 p.m.)


Review request for Ambari, Alejandro Fernandez, Di Li, Jayush Luniya, and Juanjo  Marron.


Bugs: AMBARI-18865
    https://issues.apache.org/jira/browse/AMBARI-18865


Repository: ambari


Description
-------

Updated to remove deprecated property and updated property in latest release


Diffs
-----

  ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka-broker.xml 96b7750 


Diff: https://reviews.apache.org/r/56677/diff/2/


Testing
-------


Thanks,

Bharat Viswanadham


Re: Review Request 56677: Kafka still showing deprecated property log.cleanup.interval.mins in Config Section of Kafka on Ambari

Posted by Bharat Viswanadham <bh...@us.ibm.com>.

> On April 17, 2017, 5:49 p.m., Alejandro Fernandez wrote:
> > Pushed to trunk,
> > commit 6806d38b8526f5229a6ed4a56a4492f2b2ab27c2

Thank you Alejandro Fernandez


- Bharat


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56677/#review172107
-----------------------------------------------------------


On April 13, 2017, 8:44 p.m., Bharat Viswanadham wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56677/
> -----------------------------------------------------------
> 
> (Updated April 13, 2017, 8:44 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Di Li, Jayush Luniya, and Juanjo  Marron.
> 
> 
> Bugs: AMBARI-18865
>     https://issues.apache.org/jira/browse/AMBARI-18865
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Updated to remove deprecated property and updated property in latest release
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka-broker.xml 96b7750 
> 
> 
> Diff: https://reviews.apache.org/r/56677/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bharat Viswanadham
> 
>


Re: Review Request 56677: Kafka still showing deprecated property log.cleanup.interval.mins in Config Section of Kafka on Ambari

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56677/#review172107
-----------------------------------------------------------



Pushed to trunk,
commit 6806d38b8526f5229a6ed4a56a4492f2b2ab27c2

- Alejandro Fernandez


On April 13, 2017, 8:44 p.m., Bharat Viswanadham wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56677/
> -----------------------------------------------------------
> 
> (Updated April 13, 2017, 8:44 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Di Li, Jayush Luniya, and Juanjo  Marron.
> 
> 
> Bugs: AMBARI-18865
>     https://issues.apache.org/jira/browse/AMBARI-18865
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Updated to remove deprecated property and updated property in latest release
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka-broker.xml 96b7750 
> 
> 
> Diff: https://reviews.apache.org/r/56677/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bharat Viswanadham
> 
>


Re: Review Request 56677: Kafka still showing deprecated property log.cleanup.interval.mins in Config Section of Kafka on Ambari

Posted by Bharat Viswanadham <bh...@us.ibm.com>.

> On April 13, 2017, 9:49 p.m., Alejandro Fernandez wrote:
> > Ship It!

Hi Alejandro Fernandez
Could you please help me in commiting this.


- Bharat


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56677/#review171943
-----------------------------------------------------------


On April 13, 2017, 8:44 p.m., Bharat Viswanadham wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56677/
> -----------------------------------------------------------
> 
> (Updated April 13, 2017, 8:44 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Di Li, Jayush Luniya, and Juanjo  Marron.
> 
> 
> Bugs: AMBARI-18865
>     https://issues.apache.org/jira/browse/AMBARI-18865
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Updated to remove deprecated property and updated property in latest release
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka-broker.xml 96b7750 
> 
> 
> Diff: https://reviews.apache.org/r/56677/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bharat Viswanadham
> 
>


Re: Review Request 56677: Kafka still showing deprecated property log.cleanup.interval.mins in Config Section of Kafka on Ambari

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56677/#review171943
-----------------------------------------------------------


Ship it!




Ship It!

- Alejandro Fernandez


On April 13, 2017, 8:44 p.m., Bharat Viswanadham wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56677/
> -----------------------------------------------------------
> 
> (Updated April 13, 2017, 8:44 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Di Li, Jayush Luniya, and Juanjo  Marron.
> 
> 
> Bugs: AMBARI-18865
>     https://issues.apache.org/jira/browse/AMBARI-18865
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Updated to remove deprecated property and updated property in latest release
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka-broker.xml 96b7750 
> 
> 
> Diff: https://reviews.apache.org/r/56677/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bharat Viswanadham
> 
>