You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "xiaocairush (via GitHub)" <gi...@apache.org> on 2023/06/20 13:25:53 UTC
[GitHub] [kafka] xiaocairush opened a new pull request, #13885: MINOR: Fix typos for connect
xiaocairush opened a new pull request, #13885:
URL: https://github.com/apache/kafka/pull/13885
*More detailed description of your change,
Fix typos for connect*
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] xiaocairush commented on a diff in pull request #13885: MINOR: Fix typos for connect
Posted by "xiaocairush (via GitHub)" <gi...@apache.org>.
xiaocairush commented on code in PR #13885:
URL: https://github.com/apache/kafka/pull/13885#discussion_r1235458225
##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConnector.java:
##########
@@ -271,12 +271,12 @@ public synchronized void shutdown() {
void doShutdown() {
try {
- TargetState preEmptedState = pendingTargetStateChange.getAndSet(null);
+ TargetState preEmptiedState = pendingTargetStateChange.getAndSet(null);
Review Comment:
revert all false positive fix in WorkerConnector
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] C0urante commented on a diff in pull request #13885: MINOR: Fix typos for connect
Posted by "C0urante (via GitHub)" <gi...@apache.org>.
C0urante commented on code in PR #13885:
URL: https://github.com/apache/kafka/pull/13885#discussion_r1235437562
##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConnector.java:
##########
@@ -325,20 +325,20 @@ public boolean awaitShutdown(long timeoutMs) {
}
public void transitionTo(TargetState targetState, Callback<TargetState> stateChangeCallback) {
- Callback<TargetState> preEmptedStateChangeCallback;
- TargetState preEmptedState;
+ Callback<TargetState> preEmptiedStateChangeCallback;
+ TargetState preEmptiedState;
Review Comment:
Also incorrect
##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConnector.java:
##########
@@ -325,20 +325,20 @@ public boolean awaitShutdown(long timeoutMs) {
}
public void transitionTo(TargetState targetState, Callback<TargetState> stateChangeCallback) {
- Callback<TargetState> preEmptedStateChangeCallback;
- TargetState preEmptedState;
+ Callback<TargetState> preEmptiedStateChangeCallback;
Review Comment:
Also incorrect
##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConnector.java:
##########
@@ -325,20 +325,20 @@ public boolean awaitShutdown(long timeoutMs) {
}
public void transitionTo(TargetState targetState, Callback<TargetState> stateChangeCallback) {
- Callback<TargetState> preEmptedStateChangeCallback;
- TargetState preEmptedState;
+ Callback<TargetState> preEmptiedStateChangeCallback;
+ TargetState preEmptiedState;
synchronized (this) {
- preEmptedStateChangeCallback = pendingStateChangeCallback.getAndSet(stateChangeCallback);
- preEmptedState = pendingTargetStateChange.getAndSet(targetState);
+ preEmptiedStateChangeCallback = pendingStateChangeCallback.getAndSet(stateChangeCallback);
+ preEmptiedState = pendingTargetStateChange.getAndSet(targetState);
notify();
}
- if (preEmptedStateChangeCallback != null) {
- preEmptedStateChangeCallback.onCompletion(
+ if (preEmptiedStateChangeCallback != null) {
+ preEmptiedStateChangeCallback.onCompletion(
new ConnectException(
- "Could not begin changing connector state to " + preEmptedState.name()
+ "Could not begin changing connector state to " + preEmptiedState.name()
+ " before another request to change state was made;"
+ " the new request (which is to change the state to " + targetState.name()
- + ") has pre-empted this one"),
+ + ") has pre-emptied this one"),
Review Comment:
Also incorrect
##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConnector.java:
##########
@@ -271,12 +271,12 @@ public synchronized void shutdown() {
void doShutdown() {
try {
- TargetState preEmptedState = pendingTargetStateChange.getAndSet(null);
+ TargetState preEmptiedState = pendingTargetStateChange.getAndSet(null);
Review Comment:
This change is incorrect; "pre-empted" is the intended term.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] xiaocairush commented on a diff in pull request #13885: MINOR: Fix typos for connect
Posted by "xiaocairush (via GitHub)" <gi...@apache.org>.
xiaocairush commented on code in PR #13885:
URL: https://github.com/apache/kafka/pull/13885#discussion_r1235458225
##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConnector.java:
##########
@@ -271,12 +271,12 @@ public synchronized void shutdown() {
void doShutdown() {
try {
- TargetState preEmptedState = pendingTargetStateChange.getAndSet(null);
+ TargetState preEmptiedState = pendingTargetStateChange.getAndSet(null);
Review Comment:
Have reverted all false positive fix in WorkerConnector
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] C0urante merged pull request #13885: MINOR: Fix typos for connect
Posted by "C0urante (via GitHub)" <gi...@apache.org>.
C0urante merged PR #13885:
URL: https://github.com/apache/kafka/pull/13885
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] xiaocairush commented on a diff in pull request #13885: MINOR: Fix typos for connect
Posted by "xiaocairush (via GitHub)" <gi...@apache.org>.
xiaocairush commented on code in PR #13885:
URL: https://github.com/apache/kafka/pull/13885#discussion_r1235460018
##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConnector.java:
##########
@@ -325,20 +325,20 @@ public boolean awaitShutdown(long timeoutMs) {
}
public void transitionTo(TargetState targetState, Callback<TargetState> stateChangeCallback) {
- Callback<TargetState> preEmptedStateChangeCallback;
- TargetState preEmptedState;
+ Callback<TargetState> preEmptiedStateChangeCallback;
Review Comment:
resolved
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] xiaocairush commented on a diff in pull request #13885: MINOR: Fix typos for connect
Posted by "xiaocairush (via GitHub)" <gi...@apache.org>.
xiaocairush commented on code in PR #13885:
URL: https://github.com/apache/kafka/pull/13885#discussion_r1235455670
##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConnector.java:
##########
@@ -325,20 +325,20 @@ public boolean awaitShutdown(long timeoutMs) {
}
public void transitionTo(TargetState targetState, Callback<TargetState> stateChangeCallback) {
- Callback<TargetState> preEmptedStateChangeCallback;
- TargetState preEmptedState;
+ Callback<TargetState> preEmptiedStateChangeCallback;
+ TargetState preEmptiedState;
Review Comment:
resolved
##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConnector.java:
##########
@@ -325,20 +325,20 @@ public boolean awaitShutdown(long timeoutMs) {
}
public void transitionTo(TargetState targetState, Callback<TargetState> stateChangeCallback) {
- Callback<TargetState> preEmptedStateChangeCallback;
- TargetState preEmptedState;
+ Callback<TargetState> preEmptiedStateChangeCallback;
+ TargetState preEmptiedState;
synchronized (this) {
- preEmptedStateChangeCallback = pendingStateChangeCallback.getAndSet(stateChangeCallback);
- preEmptedState = pendingTargetStateChange.getAndSet(targetState);
+ preEmptiedStateChangeCallback = pendingStateChangeCallback.getAndSet(stateChangeCallback);
+ preEmptiedState = pendingTargetStateChange.getAndSet(targetState);
notify();
}
- if (preEmptedStateChangeCallback != null) {
- preEmptedStateChangeCallback.onCompletion(
+ if (preEmptiedStateChangeCallback != null) {
+ preEmptiedStateChangeCallback.onCompletion(
new ConnectException(
- "Could not begin changing connector state to " + preEmptedState.name()
+ "Could not begin changing connector state to " + preEmptiedState.name()
+ " before another request to change state was made;"
+ " the new request (which is to change the state to " + targetState.name()
- + ") has pre-empted this one"),
+ + ") has pre-emptied this one"),
Review Comment:
resolved
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] C0urante commented on pull request #13885: MINOR: Fix typos for connect
Posted by "C0urante (via GitHub)" <gi...@apache.org>.
C0urante commented on PR #13885:
URL: https://github.com/apache/kafka/pull/13885#issuecomment-1599050843
Thanks! Will merge pending CI build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org