You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "Tomas Eduardo Fernandez Lobbe (Jira)" <ji...@apache.org> on 2023/03/09 23:17:00 UTC
[jira] [Commented] (SOLR-16692) Evaluate using Empty CookieStore
[ https://issues.apache.org/jira/browse/SOLR-16692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17698646#comment-17698646 ]
Tomas Eduardo Fernandez Lobbe commented on SOLR-16692:
------------------------------------------------------
I ran the benchmark in the PR and I got:
Empty Cookie (Patch):
Benchmark Mode Cnt Score Error Units
SimpleSearch.query thrpt 9 42040.067 ± 2515.191 ops/s
(Main)
Benchmark Mode Cnt Score Error Units
SimpleSearch.query thrpt 9 40051.328 ± 3657.889 ops/s
This is the part of the flame graph that this PR affects:
!image-2023-03-09-15-15-07-793.png!
> Evaluate using Empty CookieStore
> --------------------------------
>
> Key: SOLR-16692
> URL: https://issues.apache.org/jira/browse/SOLR-16692
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: SolrJ
> Reporter: Tomas Eduardo Fernandez Lobbe
> Priority: Minor
> Attachments: image-2023-03-09-15-15-07-793.png
>
>
> I noticed when running SolrJ app with a profiler that there is some time spent in {{{}InMemoryCookieStore.get(URI){}}}. It's not a lot, but it's something and it has a lock so I'm guessing it may be worse with high number of threads.
> Searching in the code, I can see the Kerberos auth seems to use cookies, but I can't see anything else. I'm thinking we should at least make the CookieStore optional, or maybe just enable it for Kerberos, unless I'm missing something
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org