You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by corneadoug <gi...@git.apache.org> on 2016/02/01 00:57:06 UTC

[GitHub] incubator-zeppelin pull request: [Zeppelin-635] AngularJS utilitie...

Github user corneadoug commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/678#issuecomment-177663551
  
    I just reviewed the code (didn't try the PR yet).
    It looks pretty nice.
    
    For the show paragraphID, since it is an utility, maybe we could only show that ID as the top line of the settings drop down. That way we wouldn't need to toggle it nor to hide it depending on the view (report view) and we could copy paste it (hopefully).
    
    +1 for the `z.` and bind/unbind as names


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---