You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/06/23 09:47:47 UTC

[GitHub] [nifi] tpalfy commented on a change in pull request #4350: NIFI-6934 In PutDatabaseRecord added Postgres UPSERT support

tpalfy commented on a change in pull request #4350:
URL: https://github.com/apache/nifi/pull/4350#discussion_r444100533



##########
File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutDatabaseRecord.java
##########
@@ -101,6 +106,7 @@
     static final String UPDATE_TYPE = "UPDATE";
     static final String INSERT_TYPE = "INSERT";
     static final String DELETE_TYPE = "DELETE";
+    static final String UPSERT_TYPE = "UPSERT";

Review comment:
       `UPSERT` is a fairly widespread expression, although not a standard.
   
   The standard would be `MERGE` but many RDBMS - Postgres for one - doesn't support it. (And it's a more than 10 year old standard so I guess we'll just have to live without it.)
   
   Okay, let's got with "UPDATE_OR_INSERT" to describe the _concept_.
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org