You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/09/27 11:22:36 UTC

[GitHub] [tvm] chiwwang commented on pull request #8668: Visualization of Relay IR

chiwwang commented on pull request #8668:
URL: https://github.com/apache/tvm/pull/8668#issuecomment-927778726


   After discussing with @kueitang, I will pick up this PR and fix problems according to reviews :)
   
   I have some quick answers here --
   Thanks @PhilippvK @corehalt , I tried BYOC partitions.
   If I understand correctly, BYOC annotate a segment of codes to use another compiler. The segment of codes is then separated as a `GlobalVar`.
   Multiple `GlobalVar` is supported!
   So the figure looks like:
   ![圖片](https://user-images.githubusercontent.com/84191062/134898295-d6aa2803-0a68-4b0d-81e6-a8a32f4a21b4.png)
   In the same html,
   ![圖片](https://user-images.githubusercontent.com/84191062/134898382-264a23f7-4c42-45cf-87ab-6402724979fb.png)
   
   Thanks @areusch for reviewing!
   I will fix problems in days.
   Also, I agree with `bokeh` is too heavyweight to be a dependency.
   That's why I use lazy-importing -- `bokeh` can be just optional for users who want to use.
   I will add more comments in codes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org